Fix auth in UI with LDAP if password authentication is disabled

[minurmin]

References

• Fixes Couldn't auth in UI with LDAP if password authentication disabled DSpace#8312 (see also discussion in duplicate issue Login dropdown is blank when only LDAP authentication is enabled #2701)
• Expands on Made it possible to reorder the login methods #2414

Description

If LDAP authentication is enabled but Password authentication is not, Angular UI shows a blank login dialog. This PR fixes the issue by forcing Password dialog to be present (as the same password dialog is used in both password- and ldap-based authentication) as part of the enumeration and sorting of login methods.

Instructions for Reviewers

Details on functionality: When enumerating the authentication methods for sorting, additional local variables to record whether password auth and/or ldap auth are present. In the special case where ldap auth is present and password auth is not, password auth is added anyway. This is needed because there is no renderAuthMethodFor decorator related to ldap auth (and overall, ldap auth is barely referenced anywhere outside the auth.method.ts as the UI is the same for password authentication). Because of the new variables the form will appear only once compared to the situation where a decorator would be present both password and ldap auth (as mentioned in discussion of #2701).

So far, the code has only been tested with DSpace 7.6.x. However, there seems to be no essential changes in auth.interceptor.ts after introducing the reordering functionality #2414 so it's at least mergeable to main branch as well.

Steps to test the issue (i.e. adjusting values of plugin.sequence.org.dspace.authenticate.AuthenticationMethod in DSpace server settings) are described in DSpace/DSpace#8312

Checklist

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

@minurmin : This has some lint errors which you can see from the "Files changed" tab https://github.com/DSpace/dspace-angular/pull/3912/files It might be possible to fix them automatically by running npm run lint-fix

[minurmin]

Ok, it should pass lint validation now.

[tdonohue]

👍 Thanks @minurmin ! I reviewed and tested this today, and verified it works. It's perhaps not the perfect solution (as it requires some extra logic to check which auth methods are enabled specific to LDAP), but it seems "good enough" because it solves the immediate bug.

So, I'm going to go ahead and merge this & port to 8.x and 7.x

[dspace-bot]

Successfully created backport PR for dspace-7_x:

• [Port dspace-7_x] Fix auth in UI with LDAP if password authentication is disabled #3929

[dspace-bot]

Successfully created backport PR for dspace-8_x:

• [Port dspace-8_x] Fix auth in UI with LDAP if password authentication is disabled #3930