Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YAML syntax in config.example.yml #3920

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

tdonohue
Copy link
Member

Description

This PR fixes a minor syntax error in our config.example.yml added in #3709

Because this example file is only for documentation purposes, we overlooked that these example configs were not valid YAML.

This needs to be ported to 8.x as well, since it exists there. A manual port will need to be done for 7.x

@tdonohue tdonohue added configuration 1 APPROVAL pull request only requires a single approval to merge port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jan 29, 2025
@tdonohue tdonohue changed the title Fix syntax in config.example.yml Fix YAML syntax in config.example.yml Jan 29, 2025
@tdonohue tdonohue added this to the 9.0 milestone Jan 29, 2025
@tdonohue
Copy link
Member Author

Merging immediately as this is essentially a documentation fix & passes all tests. This example file merely documents our configs.

@tdonohue tdonohue merged commit e867993 into DSpace:main Jan 29, 2025
15 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@tdonohue tdonohue deleted the config_syntax branch January 29, 2025 22:39
@tdonohue tdonohue removed the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge configuration
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants