Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port dspace-8_x] Provide a setting to use a different REST url during SSR execution #3953

Merged
merged 10 commits into from
Feb 6, 2025

Conversation

atarix83
Copy link
Contributor

@atarix83 atarix83 commented Feb 4, 2025

References

Description

This the PR based on dspace-8_x branch for #3358

Instructions for Reviewers

See details #3358

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@atarix83 atarix83 changed the title Task/dspace 8 x/duracom 288 Provide a setting to use a different REST url during SSR execution dspace 8 x Feb 4, 2025
@tdonohue tdonohue changed the title Provide a setting to use a different REST url during SSR execution dspace 8 x [Port dspace-8_x] Provide a setting to use a different REST url during SSR execution Feb 4, 2025
@tdonohue tdonohue added high priority performance / caching Related to performance, caching or embedded objects labels Feb 4, 2025
@tdonohue tdonohue added this to the 8.1 milestone Feb 4, 2025
@tdonohue tdonohue requested review from tdonohue and pnbecker February 4, 2025 19:41
@pnbecker
Copy link
Member

pnbecker commented Feb 5, 2025

I tested this PR in a production environment. There were two URLs to access the backend: one was accessible only from my browser, the other one from the frontend. The one accessible from my browser filtered the access based on the connecting ip address, the other one was routed via a private IP address space which my browser had no access to. The frontend was able to access the backend only via the private ip.

I was able to login, to submit a new Item, to load thumbnails and files with JavaScript switched off, and to load the sitemap. I was not able to search and browse without JavaScript, which is not a surprise after we merged the PR to limit SSR to certain paths and to exclude search and browse from ssr.

👍 I did not review the code, I just tested it.

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @atarix83 ! I've verified this is an identical backport of #3358, and it's been tested by @pnbecker . So, merging this immediately for 8.1

@tdonohue tdonohue merged commit 59e6c4a into DSpace:dspace-8_x Feb 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority performance / caching Related to performance, caching or embedded objects
Projects
Development

Successfully merging this pull request may close these issues.

5 participants