-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Port dspace-7_x] Provide a setting to use a different REST url during SSR execution #3962
Merged
tdonohue
merged 11 commits into
DSpace:dspace-7_x
from
4Science:task/dspace-7_x/DURACOM-288
Feb 7, 2025
Merged
[Port dspace-7_x] Provide a setting to use a different REST url during SSR execution #3962
tdonohue
merged 11 commits into
DSpace:dspace-7_x
from
4Science:task/dspace-7_x/DURACOM-288
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…R execution # Conflicts: # src/app/app.config.ts # src/app/core/services/server-hard-redirect.service.spec.ts # src/app/core/services/server-hard-redirect.service.ts # src/app/thumbnail/thumbnail.component.ts # src/modules/app/browser-init.service.ts # src/modules/app/server-init.service.ts
10 tasks
@atarix83 : This PR is having test failures. It looks like it may need minor updates to fix unit tests/specs |
tdonohue
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @atarix83 ! I manually tested this today and it's working in 7.x Also verified that the code here is the same as the main
PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
This the PR based on dspace-7_x branch for #3358
Instructions for Reviewers
See details #3358
Checklist
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint
npm run check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.