[hotfix-#1771] [connector][starrocks] The sr table was not partitioned, causing data consumption to fail but the flink task presentation to succeed #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…titioned, causing data consumption to fail but the flink task presentation to succeed
lvyanquan
reviewed
Jul 26, 2023
| if (!streamLoadManager.tableHasPartition()) { | ||
| throw new RuntimeException( | ||
| "data cannot be inserted into table with empty partition. " | ||
| + "Use `SHOW PARTITIONS FROM star_test` to see the currently partitions of this table"); |
There was a problem hiding this comment.
what does star_test mean?
There was a problem hiding this comment.
。。。 My mistake。Should be the output table name
lvyanquan
reviewed
Jul 26, 2023
| try { | ||
| jdbcConnProvider.checkValid(); | ||
| final String query = "SHOW PARTITIONS FROM " + database + "." + table + ";"; | ||
| PreparedStatement stmt = jdbcConnProvider.getConnection().prepareStatement(query); |
There was a problem hiding this comment.
better to close those resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
修复因为starrocks没有创建分区，导致任务失败但flink任务实际展示为成功，且有写成功条数等信息
Which issue you fix
Fixes #1771 (issue).