Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MemberIdentity에서 currentCohort 제거 #191

Closed
DaleSeo opened this issue Jan 10, 2025 · 2 comments · Fixed by #192
Closed

MemberIdentity에서 currentCohort 제거 #191

DaleSeo opened this issue Jan 10, 2025 · 2 comments · Fixed by #192
Assignees
@HC-kang

Comments

@DaleSeo
Copy link
Contributor

DaleSeo commented Jan 10, 2025

PR #116 에서 MemberIdentity에 chorts가 추가될 때, backward compatibility를 위해서 currentCohort도 함께 추가됨. 그런데 로직을 보면 currentCohort는 항상 chorts.at(-1)이 되는 것 같음. currentCohort를 제거하면 복잡도가 낮아지지 않을까?
@DaleSeo DaleSeo converted this from a draft issue Jan 10, 2025
@DaleSeo
Copy link
Contributor Author

DaleSeo commented Jan 10, 2025

이 리펙토링 티켓 @HC-kang 님을 염두해두고 만들어 놓은 겁니다. 아무래도 프론트엔드 개발에 참여하실 의향이 전혀 없으신 것 같아서요 ㅋㅋ

@HC-kang HC-kang self-assigned this Jan 11, 2025
@HC-kang HC-kang linked a pull request Jan 11, 2025 that will close this issue
불필요한 currentCohort 속성 제거 #192
Merged
2 tasks
@HC-kang HC-kang moved this from Todo to In Progress in 리더보드 Jan 11, 2025
@HC-kang
Copy link
Contributor

HC-kang commented Jan 11, 2025

프론트엔드 개발에 참여할 의향이 없다기보다는, 어느순간 흐름을 놓쳐버렸네요😿
미약하지만..ㅋㅋ 개인 홈페이지도 만들고 하면서 흥미를 키워가고는 있는데 쉽지는 않네요... ㅋㅋ

@github-project-automation github-project-automation bot moved this from In Progress to Done in 리더보드 Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HC-kang HC-kang

Labels
None yet
Projects
No open projects
리더보드
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

불필요한 currentCohort 속성 제거 DaleStudy/leaderboard
2 participants
@DaleSeo @HC-kang