불필요한 currentCohort 속성 제거 #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunjae95
reviewed
Jan 11, 2025
Sunjae95
force-pushed
the
191-remove-currentcohort
branch
from
903b998 to
a4c624c
Compare
DaleSeo
approved these changes
Jan 18, 2025
Comment on lines
-63
to
+64
| existingMember.currentCohort = Math.max( | ||
| existingMember.currentCohort, | ||
| member.currentCohort, | ||
| ); | ||
| if (!existingMember.cohorts.includes(member.currentCohort)) { | ||
| existingMember.cohorts.push(member.currentCohort); | ||
| } | ||
| existingMember.cohorts = [ | ||
| ...new Set([...existingMember.cohorts, ...member.cohorts]), | ||
| ]; |
HC-kang
force-pushed
the
191-remove-currentcohort
branch
from
4fc341c to
a7dc799
Compare
HC-kang
force-pushed
the
191-remove-currentcohort
branch
from
a7dc799 to
c5bef86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요즘 주중에 신경을 너무 못썼네요.. 늦었지만 이제야 PR 올립니다.
불필요한 currentCohort 속성을 제거했습니다.
체크리스트