-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination 컴포넌트 구현 및 적용 #212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3c6a3e5
to
723ad3d
Compare
723ad3d
to
6cbc04d
Compare
6cbc04d
to
de16fce
Compare
de16fce
to
17ae7e1
Compare
@Sunjae95 저희가 필터링 이후에 pagination을 초기화해야 한다는 스펙을 놓쳤네요! 이 부분 추가로 보강해야겠습니다. |
ad488d1
to
2625687
Compare
Sunjae95
approved these changes
Jan 26, 2025
Comment on lines
+31
to
+34
useEffect(() => { | ||
setCurrentPage(1); | ||
}, [totalItems]); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
Co-authored-by: 이선재 <[email protected]>
Co-authored-by: SeonjaeLee <[email protected]>
4a30cd0
to
c5ecb81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
체크리스트
Preview