Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination 컴포넌트 구현 및 적용 #212

Merged
merged 6 commits into from
Jan 26, 2025
Merged

Pagination 컴포넌트 구현 및 적용 #212

merged 6 commits into from
Jan 26, 2025

Conversation

sounmind
Copy link
Member

@sounmind sounmind commented Jan 18, 2025

체크리스트

  • 이슈가 연결되어 있나요?
  • 배포 후 브라우저 콘솔에 경고나 오류가 있나요?

Preview

image

image

@sounmind sounmind linked an issue Jan 18, 2025 that may be closed by this pull request
@sounmind sounmind marked this pull request as ready for review January 25, 2025 23:06
@sounmind sounmind requested a review from a team as a code owner January 25, 2025 23:06
@sounmind sounmind changed the title feat: Pagination component Pagination 컴포넌트 구현 및 적용 Jan 25, 2025
@sounmind
Copy link
Member Author

@Sunjae95 저희가 필터링 이후에 pagination을 초기화해야 한다는 스펙을 놓쳤네요! 이 부분 추가로 보강해야겠습니다.
https://github.com/user-attachments/assets/e91726d9-8a13-4350-b0ff-d613b6c4fc0f

Comment on lines +31 to +34
useEffect(() => {
setCurrentPage(1);
}, [totalItems]);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@sounmind sounmind merged commit 09fc989 into main Jan 26, 2025
6 checks passed
@sounmind sounmind deleted the 204-pagination branch January 26, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

페이지네이션 컴포넌트 구현
2 participants