Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

디스코드 링크에 단축 URL 사용 #202

Merged
merged 1 commit into from
Nov 17, 2024
Merged

디스코드 링크에 단축 URL 사용 #202

merged 1 commit into from
Nov 17, 2024

Conversation

DaleSeo
Copy link
Contributor

@DaleSeo DaleSeo commented Nov 17, 2024

디스코드 초대 링크에 대한 단축 URL을 만들었습니다: https://dales.link/discord
디스코드 초대 링크는 새로 생성할 때 URL내 해시값이 바뀌는데요. 그래서 일일이 찾아서 업데이트해주는 게 번거롭고 놓치기도 쉽습니다. 단축 URL을 사용하면 이러한 문제를 쉽게 예방할 수 있습니다. 단순히 단축 URL이 가리키는 디스코드 초대 링크만 바꿔주면 되니까요.

@DaleSeo DaleSeo self-assigned this Nov 17, 2024
@DaleSeo DaleSeo requested a review from a team as a code owner November 17, 2024 16:53
Copy link
Contributor

@SamTheKorean SamTheKorean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

단축 url이 있었군요! 유지보수가 더 용이해지겠네요~! 고생하셨습니다!

@@ -33,7 +33,7 @@ class ParticipantReviewsSection extends HTMLElement {
createHtml() {
return html`
<section>
<ds-hero>참가자 후기</ds-hero>
<ds-hero>참여자 후기</ds-hero>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"참가" 보다는 "참여"가 어감이 더 나은 것 같아서 수정합니다. 웹사이트의 다른 부분에도 "참여"라는 용어를 쓰고 있네요.

@DaleSeo DaleSeo merged commit debd54b into main Nov 17, 2024
1 check passed
@DaleSeo DaleSeo deleted the shorten-url branch November 17, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants