Sentry issue fixes #1294
Open
Sentry issue fixes #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1294 +/- ##
==========================================
- Coverage 71.27% 71.26% -0.01%
==========================================
Files 98 98
Lines 6788 6790 +2
Branches 1537 1534 -3
==========================================
+ Hits 4838 4839 +1
+ Misses 1921 1836 -85
- Partials 29 115 +86 ☔ View full report in Codecov by Sentry. |
fatchat
reviewed
Nov 7, 2024
| const count = await httpGet(session, `warehouse/table_count/${schema}/${table}`); | ||
| setRowCount(count.total_rows); | ||
| try { | ||
| const count = await httpGet(session, `warehouse/table_count/${schema}/${table}`); |
There was a problem hiding this comment.
but why are we asking for rows and columns of a table which doesn't exist
the error is in the backend, a try-catch here won't stop the error from happening
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.