Uh oh #37
Open
Uh oh #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etectionHost
As one of the MPArch tasks, ClientSideDetectionHost has to migrate
GetAllFrames to ForEachRenderFrameHost in order to make the caller of
GetAllFrames aware MPArch related pages (e.g. bfcache, prerendering
pages). So, this CL replaces the for loop with
WebContents::ForEachRenderFrameHost with a callback.
Lastly, this CL add a new browser test in order to check if the
prerendered page can complete the classification of phishing detection
after activating.
TEST=ClientSideDetectionHostPrerenderBrowserTest.
ClassifyPrerenderedPageAfterActivation
Bug: 1208438, 1219142
Change-Id: I903a110b07e9b7be5a1001bc32917668fd6dd2a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992774
Commit-Queue: Gyuyoung Kim <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Reviewed-by: Kevin McNee <[email protected]>
Cr-Commit-Position: refs/heads/master@{#897613}
This CL adds updated connection security icons for Android. The icons were added as vector images on desktop, and aren't reused on Android. The .png files are optimized using tools/resources/optimize-png-files.sh A future CL will convert all connection security icons including the current lock icon to vector icons. This is tracked at https://crbug.com/1225080. Bug: 1204293 Change-Id: If61192fe74865be1cf36ba8a22aa0640abcfefc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2981083 Commit-Queue: Mustafa Emre Acer <[email protected]> Reviewed-by: Liquan (Max) Gu <[email protected]> Reviewed-by: Theresa <[email protected]> Reviewed-by: Evan Stade <[email protected]> Reviewed-by: Patrick Noland <[email protected]> Reviewed-by: Tommy Li <[email protected]> Cr-Commit-Position: refs/heads/master@{#897614}
This CL will add skew tests for version 91.0.4472.150. See crbug.com/1041619 and crbug.com/1099017 for more information. [email protected] Bug: None Change-Id: Ib2f0d9841e1ce18f45ea95e179f7a1fb11e8200a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2998625 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/master@{#897615}
As one of the MPArch tasks, non-primary main frame navigations (e.g. prerendering) should not affect SSLErrorHandler. In other words, the primary mainframe only can affect SSLErrorHandler. So, this CL migrates IsInMainFrame() to IsInPrimaryMainFrame() in SSLErrorHandler::DidStartNavigation in order to block doing somethings on non-primary frames. And, this CL adds a new unit test to check if the non-primary frame navigations cannot affect SSLErrorHandler. Bug: 1223816 Change-Id: I8e5cd141efd179775907ab2a68b5f1126d9fbb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2988989 Reviewed-by: Daniel Rubery <[email protected]> Reviewed-by: Lucas Gadani <[email protected]> Reviewed-by: Alexander Timin <[email protected]> Commit-Queue: Gyuyoung Kim <[email protected]> Cr-Commit-Position: refs/heads/master@{#897616}
Bug: 1224218 Change-Id: I1f9ab98e294122d4ed12a43742d405ba0e4e529c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992529 Commit-Queue: Thomas Lukaszewicz <[email protected]> Reviewed-by: Collin Baker <[email protected]> Reviewed-by: Caroline Rising <[email protected]> Cr-Commit-Position: refs/heads/master@{#897617}
ArcAccessibilityHelperBridge refactoring (5/n). This CL migrates some unit tests from ArcAccessibilityHelperBridge to ArcAccessibilityTreeTracker. This CL also does various cleanup because some methods existed only for testing and many of them are no longer needed after test migration. This also removes the dependency from ArcAccessibilityTreeTracker to ArcAccessibilityHelperBridge. Now that the dependency is not bi-directional here. AX-Relnotes: n/a. Bug: none Test: exsiting and new unit tests. Change-Id: I05dbaeaaacee5b9561ba08bb5f3723713f427913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2972213 Commit-Queue: Hiroki Sato <[email protected]> Reviewed-by: Sara Kato <[email protected]> Reviewed-by: David Tseng <[email protected]> Cr-Commit-Position: refs/heads/master@{#897618}
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/91c93fc84869..25731d21f45d $ git log 91c93fc84..25731d21f --date=short --no-merges --format='%ad %ae %s' 2021-06-30 kainino Fix byte vs element units bug; allow buffer checking by mapping (#605) 2021-06-30 bajones Review api,operation,buffers,map_detach:* (#604) 2021-06-30 corentin wgsl: add workgroup_size to all stage(compute) (#608) 2021-06-30 bclayton wgsl: [[set(n)]] is now [[group(n)]] (#607) 2021-06-30 shaobo.yan CopyToTexture,canvas basic tests : Add premultiplied alpha tests (#600) Created with: roll-dep src/third_party/webgpu-cts/src Change-Id: Id1b7a89a8c40af484c881c70a2b0ba042f6e6d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2998563 Reviewed-by: Austin Eng <[email protected]> Reviewed-by: Kai Ninomiya <[email protected]> Commit-Queue: Kai Ninomiya <[email protected]> Cr-Commit-Position: refs/heads/master@{#897619}
When running in ChromeOS we want to save board name and builder path to help automatically symbolize crashes. In the past, then entire /etc/lsb-release was saved by Breakpad. Crashpad no longer does it, which breaks 'tast symbolize' command. TEST=Manual: visited about:crash in cros vm and used minidump_dump to verify the data was saved. Bug: b:187793982 Change-Id: I86c9ca688995834218b56e8d12ff51c5fb708a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2986933 Reviewed-by: Joshua Peraza <[email protected]> Reviewed-by: Robert Sesek <[email protected]> Reviewed-by: Shuhei Takahashi <[email protected]> Commit-Queue: Tomasz Tylenda <[email protected]> Cr-Commit-Position: refs/heads/master@{#897620}
This adds a execution time for just the model running itself so we can see if it is cause the task to run too long. Bug: 1220025 Change-Id: I1be6bf6bf91783321d5c5024748f177e6592d5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2998801 Commit-Queue: Michael Crouse <[email protected]> Reviewed-by: Robert Ogden <[email protected]> Cr-Commit-Position: refs/heads/master@{#897621}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5885fbf9..49a43218 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel [email protected],[email protected],[email protected] Change-Id: Ic29b538448685c2bfa9a3391fb17b019b0b0eef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2999056 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#897622}
This change adds the collection of gRPC API targets under //third_party/openscreen/src to the linux openscreen configuration of the chromium bot recipe. This is necessary because the openscreen repo itself doesn't have gRPC. Bug: 1224703 Change-Id: Ia791f410671e38e859dd24acd295163ad981ff52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2994143 Reviewed-by: Stephen Martinis <[email protected]> Commit-Queue: Brandon Tolsch <[email protected]> Cr-Commit-Position: refs/heads/master@{#897623}
This CL adds the browser test to ensure to cancel the prerendering page when we get the network error during prerendering. Bug: 1224746 Change-Id: Id593031cc849577383fd02a4f105934ca4856a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2994090 Reviewed-by: Lucas Gadani <[email protected]> Reviewed-by: Renjie Tang <[email protected]> Commit-Queue: Miyoung Shin <[email protected]> Cr-Commit-Position: refs/heads/master@{#897624}
As per the latest spec changes, expose profiler creation synchronously on the constructor rather than through performance.profile. Bug: 956688 Change-Id: I3f8637d30c81afb21baa0f2a01565b4902bfb76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2993062 Commit-Queue: Andrew Comminos <[email protected]> Reviewed-by: Nicolás Peña Moreno <[email protected]> Cr-Commit-Position: refs/heads/master@{#897625}
Connects DriveFsEventRouter to the system notification manager for all events being sent as extension::Event. Connects EventRouter to system notification manager for the copy (progress) events. Bug: b/187656842 Change-Id: I66d606c0d334fd4f940b2789130ba6b0db0974dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2991415 Commit-Queue: Alex Danilo <[email protected]> Reviewed-by: Bo Majewski <[email protected]> Cr-Commit-Position: refs/heads/master@{#897626}
https://dawn.googlesource.com/dawn.git/+log/3a75b1cea88d..211b4aae7efe 2021-07-01 [email protected] Remove null-deref in test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: [email protected] Change-Id: I405acb5bb7793b6c269ece634e9a96e9c57fb040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2999199 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/master@{#897627}
To implement the drop feature for dragging and dropping, modules need to be re-rendered in the new order. Beforehand, Polymer's dom-repeat was used to render the modules, but dom-repeat would just reuse the module wrappers and swap the module content. This was an issue because not all of the module content are the same size. Fixed: 1223465 Change-Id: I01616cca2b4ed113723016c24928c7cf950c16e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2986669 Commit-Queue: Lydia Lam <[email protected]> Reviewed-by: Tibor Goldschwendt <[email protected]> Reviewed-by: Moe Ahmadi <[email protected]> Cr-Commit-Position: refs/heads/master@{#897628}
ImeService needs to know whether RuleBasedEngine or SystemEngine is connected, in order to prevent DecoderEngine from overriding the connection. Right now, ImeService passes a callback to RuleBasedEngine/ SystemEngine that is called when disconnection occurs. The callback is stateful and captures ImeService to record the disconnection. However, in subsequent CLs, SystemEngine will be replaced a C API, so the callback needs to be passed via C. In C, callbacks are stateless, so this will break. Although we could pass a void* context object to the callback that encapsulates the state, it is much easier to just query the state directly via a function call. Bug: 1194372 Change-Id: I9664e6df99a619c24630b2f85f82026f704103da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2984539 Commit-Queue: Darren Shen <[email protected]> Reviewed-by: Jing Wang <[email protected]> Cr-Commit-Position: refs/heads/master@{#897629}
This CL will add skew tests for version 92.0.4515.82. See crbug.com/1041619 and crbug.com/1099017 for more information. [email protected] Bug: None Change-Id: I5d7dd39a5ebb3d20261315bfd18ecb332d1d2832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2999463 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/master@{#897630}
Each stream update between SurfaceUpdater::LoadStreamStarted() and the end of SurfaceUpdater::LoadStreamComplete() results in a call to ReliabilityLoggingBridge::LogAboveTheFoldRender(). Its Java implementation logs AtfRenderStart on the first call and records a result to be logged after rendering. A callback that logs the recorded status (and "launch finished" if needed) is posted with RecyclerView.post(). We will only log the rendering events and "launch finished" if content or zero-state slices were sent to the surface. Bug: 1195940 Change-Id: Ic35ca63734778f3e3061ee4fcd84303ea7eb925d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2994145 Commit-Queue: Ian Wells <[email protected]> Reviewed-by: Dan H <[email protected]> Cr-Commit-Position: refs/heads/master@{#897631}
The non-Impl version got renamed in https://crrev.com/c/2896112 but it seems that I forgot to rename the Impl version. Change-Id: Ie9f857fc2c8e4da46cc0a644693ad611e957515b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992794 Commit-Queue: Matt Falkenhagen <[email protected]> Auto-Submit: Fergal Daly <[email protected]> Reviewed-by: Matt Falkenhagen <[email protected]> Cr-Commit-Position: refs/heads/master@{#897632}
This patch contains the following changes: 1. Remove raw clipboard option from `ClipboardItemOptions`. 2. Remove raw clipboard async reader/writer APIs. 3. Rename `direct` to `unsanitized`. 4. Change permission for clipboard read/write to check for custom format and not raw clipboard option. Prototype: crrev.com/c/2921023. i2p: https://groups.google.com/a/chromium.org/g/blink-dev/c/Lo7WBM_v_LY/m/LncCKkXeAwAJ Bug: 106449, 1217643 Change-Id: Ia1681759862e141262224294ffc37d147231d983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2971054 Commit-Queue: Anupam Snigdha <[email protected]> Reviewed-by: Darwin Huang <[email protected]> Cr-Commit-Position: refs/heads/master@{#897633}
This CL includes the following: 1. Ensure MerchantViewerDataManagerFactory is initialized on profile creation. 2. Add the capability of force removing all merchants data controlled by a param. Bug: 1220126 Change-Id: I6f76e2e487d8fe44fa41402b1bbbdeddce5af9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2999191 Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]> Reviewed-by: David Trainor <[email protected]> Commit-Queue: Ayman Almadhoun <[email protected]> Cr-Commit-Position: refs/heads/master@{#897634}
# This is an automated release commit. # Do not revert without consulting [email protected]. NOAUTOREVERT=true Change-Id: I57ec6a1ab52e190d2c953d05781b6f3a1f8e990c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2999465 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#897635}
Bug: 1066980 Change-Id: Id0fab9e5eeac07e32d488573f0accdc5cb7c486e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2997150 Commit-Queue: Peter Kasting <[email protected]> Auto-Submit: Peter Kasting <[email protected]> Reviewed-by: Ryan Sleevi <[email protected]> Cr-Commit-Position: refs/heads/master@{#897636}
This reverts commit c2125cb. Reason for revert: Causing test failure on https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel Original change's description: > Support opening in-progress downloads on completion. > > Per product requirement, it should be possible to trigger in-progress > downloads to open on completion. This CL adds support for delayed > opening of in-progress items although only the download case is wired > up until such time as other types require similar capabilities. > > Bug: 1184438 > Change-Id: Ie3f2059f91b779ff202133852f90201a37f6b8e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2994037 > Commit-Queue: David Black <[email protected]> > Reviewed-by: Toni Baržić <[email protected]> > Reviewed-by: Min Qin <[email protected]> > Cr-Commit-Position: refs/heads/master@{#897567} Bug: 1184438 Change-Id: I2cb64f3c52d0c69911f07cd4a1e4790732dd20c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2998184 Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: David Black <[email protected]> Commit-Queue: Lei Zhang <[email protected]> Owners-Override: Lei Zhang <[email protected]> Cr-Commit-Position: refs/heads/master@{#897637}
This CL updates the network request related parameter (buffer data limit and timeout) in finich_trial_config to match what we are likely to ship. Change-Id: I8bcd659690ad92ef6bf55024115a35b9d3117c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992790 Reviewed-by: Fergal Daly <[email protected]> Commit-Queue: Yuzu Saijo <[email protected]> Cr-Commit-Position: refs/heads/master@{#897638}
This makes it possible for individual XR devices to report their supported XRSessionFeatures instead of hard-coding them in content/browser/xr's browser_xr_runtime. Change-Id: I94a995426d0e541c29bc128039423d5bee04661c Bug: 995377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2987339 Reviewed-by: Dmitry Gozman <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Reviewed-by: Alexander Cooper <[email protected]> Reviewed-by: Bo <[email protected]> Reviewed-by: Klaus Weidner <[email protected]> Reviewed-by: Chris Palmer <[email protected]> Commit-Queue: Viatcheslav Ostapenko <[email protected]> Cr-Commit-Position: refs/heads/master@{#897639}
Verified by making whitespace changes to .java files and running git cl presubmit and git cl presubmit --upload. Bug: 1211945 Change-Id: I209b5a775ad828eec043e165e0aa44ac7e530929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2998170 Reviewed-by: Bo <[email protected]> Commit-Queue: Keren Zhu <[email protected]> Cr-Commit-Position: refs/heads/master@{#897640}
huangdarwin@ will no longer be active on Chromium soon, so removing from OWNERS. Bug: 1225482 Change-Id: Ic760d7128829bcb8a05fcd9d2dc0a38de4454ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2999186 Auto-Submit: Darwin Huang <[email protected]> Commit-Queue: Daniel Murphy <[email protected]> Reviewed-by: Daniel Murphy <[email protected]> Cr-Commit-Position: refs/heads/master@{#897641}
BUG=b/181088573 Change-Id: I9d21e80c2f9c101f2af80bc6fc2d5e3058223e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2966703 Commit-Queue: John Palmer <[email protected]> Reviewed-by: calamity <[email protected]> Cr-Commit-Position: refs/heads/master@{#897642}
This brings the behavior to parity with the other port types. A test was added to cover this case. Additionally, the invocation of CreateMessagePortCorePair was fixed. Tests were changed to parameterized tests so all tests that can run on a build run, instead of having test coverage based on the current platform port type. Bug: None Change-Id: I95f663e2866ecd77f0137b894862e1228ca870aa Tested: //components/cast/message_port:message_port_unittests updated Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2999069 Commit-Queue: Shawn Quereshi <[email protected]> Reviewed-by: Sean Topping <[email protected]> Reviewed-by: Kevin Marshall <[email protected]> Reviewed-by: Ryan Keane <[email protected]> Cr-Commit-Position: refs/heads/master@{#897833}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f4c1e15f..ae5aef9f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel [email protected],[email protected],[email protected] Change-Id: I5c1753dc553d73f64f9fdc803c4f148090e2c830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3000833 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#897834}
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/9303368e6bba..ed4a85ec990b 2021-07-01 [email protected] [runtimes] Simplify how we specify XFAIL & friends based on the triple If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/libunwind-chromium Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected],[email protected] Change-Id: I83889136995f172ea0cf925eaed07183d07e7d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3001016 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/master@{#897835}
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d46361bc7be2..ae0481e55f1c 2021-07-01 [email protected] [runtimes] Simplify how we specify XFAIL & friends based on the triple If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/libcxxabi-chromium Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected],[email protected] Change-Id: Iab6b4d8a8152668336c8f771c7e57f88f99838e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3001754 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/master@{#897836}
Since neither of these are constructors, this is not exposing any new functionality, but simply exposing the interface objects as required by spec. Feature detection for |'thing' in SpeechSynthesis.prototype| was already possible using |'thing' in window.speechSynthesis|, but this does make it easier to detect members of SpeechSynthesisVoice. Note that SpeechSynthesisEvent, SpeechSynthesisErrorEvent and SpeechSynthesisUtterance interface objects were already exposed. Intent to Ship with 3xLGTM: https://groups.google.com/a/chromium.org/g/blink-dev/c/jFvTG8AJfnQ/m/Sfs4rZMQAQAJ Bug: 1224942 Change-Id: Ic3ec385a75d78ff189dba2268100038a9e6af46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2648485 Auto-Submit: Philip Jägenstedt <[email protected]> Commit-Queue: Chris Harrelson <[email protected]> Reviewed-by: Chris Harrelson <[email protected]> Cr-Commit-Position: refs/heads/master@{#897837}
Bug: 1212073 Change-Id: I8dc127ff8514622f988d990eb63a6b15f0c6188e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2980203 Reviewed-by: Aleks Totic <[email protected]> Reviewed-by: Mason Freed <[email protected]> Auto-Submit: Fabrice de Gans <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/master@{#897838}
This allows use on Linux of the XDG portal for file selection rather than directly calling out to the GTK/KDE dialogs. When the feature is enabled, a test is run asynchronously with the main thread's UI initialization to determine if the file chooser portal is available on the bus, and if so, it will be used as the default once the first dialog is opened. In order for this to work, support is added to the GtkUi platform code to "export" a window handle that can be shared with other clients of the display server (a hex ID on X11 or an xdg-foreign handle on Wayland). This handle can then be passed to the portal to ensure a transient dialog is created. Bug: 885292 Change-Id: I98ac13e93af59bc5069b68fac5c0767b93502391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992214 Reviewed-by: Thomas Anderson <[email protected]> Reviewed-by: Nick Yamane <[email protected]> Reviewed-by: Ryo Hashimoto <[email protected]> Commit-Queue: Thomas Anderson <[email protected]> Cr-Commit-Position: refs/heads/master@{#897839}
This CL adds jank metric recording to the omnibox while focused. This will track perceived jank while users are typing and scrolling through omnibox suggestions. Bug: 1212233, b/184200663 Change-Id: Iff50106ee82048977b65d1805d254868ac3c19f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2971193 Reviewed-by: Salvador Guerrero <[email protected]> Reviewed-by: Filip Gorski <[email protected]> Reviewed-by: Tomasz Wiszkowski <[email protected]> Reviewed-by: Tommy Nyquist <[email protected]> Commit-Queue: Salvador Guerrero <[email protected]> Cr-Commit-Position: refs/heads/master@{#897840}
Bug: none Change-Id: Id5f59c6e462e0a4cd7ca8ca484700a6b21731042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2999366 Reviewed-by: Nico Weber <[email protected]> Commit-Queue: Nico Weber <[email protected]> Cr-Commit-Position: refs/heads/master@{#897841}
Threading_primitives.h is heavily used in Blink and was including Windows.h. It only needs CRITICAL_SECTION and CONDITION_VARIABLE and it is "easy" to define placeholder structures of the appropriate size. The main challenge was updating the implicit dependencies on when and where various Windows.h macros are supposed to be defined and undefined. In some translation units Windows.h is still included, but now later, so fixups are required. This change drops the number of translation units that use Windows.h in a build of the chrome target from ~14,250 to 8,545, moving third_party/blink from first place to 7th. That is a 40% drop, and will unlock even more drops. Bug: 796644 Change-Id: Iedbad3dafb9f9076f334a9ab57b034169448f93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2973345 Reviewed-by: Jochen Eisinger <[email protected]> Commit-Queue: Bruce Dawson <[email protected]> Cr-Commit-Position: refs/heads/master@{#897842}
This mock object was using ON_CALL(), which prints an "Uninteresting mock function call" warning for each call to a mocked method. Using EXPECT_CALL() instead will suppress these warnings. BUG=1225615 Change-Id: Iec7c9a2d40e819c0a1804854dcabd2b364cade46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2999723 Reviewed-by: Justin Cohen <[email protected]> Commit-Queue: Rohit Rao <[email protected]> Cr-Commit-Position: refs/heads/master@{#897843}
BroadcastReceiver. The QuickActionSearchWidgetProvider will only handle widget specific logic (things such as setting up the UI of the widget) while the new BroadcastReceiver, QuickActionSearchWidgetReceiver, will handle all of the business logic (all of the functionality when users interact with the widget. When a user taps on any button on the widget, an intent is broadcast and then received be QuickActionSearchWidgetReceiver where it is handled Bug: 1213541 Change-Id: I9d4a91be4469c078e5c1d41b34bd44076746c8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2995363 Commit-Queue: Maxwell Tauro <[email protected]> Commit-Queue: Tomasz Wiszkowski <[email protected]> Reviewed-by: Tomasz Wiszkowski <[email protected]> Reviewed-by: Filip Gorski <[email protected]> Cr-Commit-Position: refs/heads/master@{#897844}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1df24b490558..e96a8e125f85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1225468,chromium:1225471 Tbr: [email protected],[email protected] Change-Id: Id8873ca4722ded8163f473f28e937863bc3fb500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3001745 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#897845}
Bug: 1218413 Change-Id: I47a44d9b299881b27ffcbe64f5b544e57148bd02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2998222 Commit-Queue: Mohamed Amir Yosef <[email protected]> Reviewed-by: David Roger <[email protected]> Reviewed-by: Christian Dullweber <[email protected]> Reviewed-by: Vasilii Sukhanov <[email protected]> Cr-Commit-Position: refs/heads/master@{#897846}
This CL updates the Tab Search entrypoint icon to use the chevron icon by default - see slide deck below. https://docs.google.com/presentation/d/1WdhU-5aA7TWix-qygo5vn_UGbK8CuMM9R5h9jmYQniE/edit#slide=id.ge1fc79e743_0_0 This CL also adds a feature flag to enable finch control over the change and allow time for UX to approve the change before releasing it more broadly. Bug: None Change-Id: I6db0d9f628324d9aa514961c524404660629ebae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2998797 Reviewed-by: Evan Stade <[email protected]> Commit-Queue: Thomas Lukaszewicz <[email protected]> Cr-Commit-Position: refs/heads/master@{#897847}
Also re-order the existing methods to match the header file. Bug: b/186906279 Test: Manual Test Change-Id: I6caad652faf03e511b338e9e7101dc20f623a98c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992533 Reviewed-by: Xiaohui Chen <[email protected]> Reviewed-by: Xiyuan Xia <[email protected]> Commit-Queue: Yue Li <[email protected]> Cr-Commit-Position: refs/heads/master@{#897848}
Move CanGetDeviceAttributes()/CanGetDeviceAttributesForBrowserContext() to browser_util so that it can be re-used by other enterprise APIs. Change-Id: I47956bd2ea2be4a145c6c9aefb1e2b8260721742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2968043 Commit-Queue: Anina Koehler <[email protected]> Reviewed-by: Maksim Ivanov <[email protected]> Reviewed-by: Erik Chen <[email protected]> Reviewed-by: Alexander Hendrich <[email protected]> Cr-Commit-Position: refs/heads/master@{#897849}
Bug: 1199123 Change-Id: I6792205d980904af442c247641db6562b0220209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3001336 Reviewed-by: Sophie Chang <[email protected]> Commit-Queue: Robert Ogden <[email protected]> Cr-Commit-Position: refs/heads/master@{#897850}
ntp-img automatically handles safe URLs via chrome://image? (chrome/browser/resources/new_tab_page/img.js) We are moving to shared location and leveraging it for nearby_device profile images. Change-Id: Iaceaa2a27001ee8052bb792f9c94f428b18bf871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2989249 Reviewed-by: dpapad <[email protected]> Reviewed-by: Josh Nohle <[email protected]> Reviewed-by: Tibor Goldschwendt <[email protected]> Commit-Queue: Dan Lee <[email protected]> Cr-Commit-Position: refs/heads/master@{#897851}
This uses the "use_fetch_checkout_workflow" where the artifacts are fetched from the call `fetch.py checkout`. See //docs/cipd_and_3pp.md for how the 3pp files will be consumed. Note the generated CIPD package will be for the platform "linux-amd64" only. Bug: 1112429 Change-Id: Ice59d3359256c2683634a8b7c0ed5ed2b51a3be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2987631 Reviewed-by: Ben Pastene <[email protected]> Reviewed-by: Brian Ryner <[email protected]> Commit-Queue: Haiyang Pan <[email protected]> Cr-Commit-Position: refs/heads/master@{#897852}
Extend the mojom struct to include the StorageKey. This allows for passing of the `key` between the //content/browser and //components/services/storage/ portions of service worker to enable registration read/writing from/to the database. Bug: 1199077 Change-Id: I9cf3db7071c0304366ba4ad834258f243aa4c53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2988229 Reviewed-by: Ben Kelly <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Commit-Queue: Steven Bingler <[email protected]> Cr-Commit-Position: refs/heads/master@{#897853}
The Skylab pipeline introduced an is_skylab arg, so this CL adds it to the builder that uses the Skylab pipeline accordingly. And additionally, the Skylab pipeline is not compatible with the chrome-on-chromeos pipeline anymore, so this CL removes the chrome-on-chromeos related test suites from the builder. Bug: 1172129 Change-Id: I3264a8e1fa4f9798302651e197159ed3ccedbb05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2990830 Reviewed-by: Xinan Lin <[email protected]> Commit-Queue: Yuke Liao <[email protected]> Cr-Commit-Position: refs/heads/master@{#897854}
Bug: 1221657 Change-Id: I49add4f281f581b0824c251262675fb42d637d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2999071 Reviewed-by: Justin DeWitt <[email protected]> Reviewed-by: Weilun Shi <[email protected]> Commit-Queue: Jian Li <[email protected]> Cr-Commit-Position: refs/heads/master@{#897855}
This CL fixed the issue of some favicons (e.g new tab page) has low contrast ratio in dark theme in WebUI tab strip. Bug: 1210233 Change-Id: I7a716ef22b9eaf89de01b59be7c0986eb7f47705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2994930 Reviewed-by: John Lee <[email protected]> Reviewed-by: Thomas Lukaszewicz <[email protected]> Commit-Queue: Yuheng Huang <[email protected]> Cr-Commit-Position: refs/heads/master@{#897856}
Due to many cls submitting today, 50% is too high for my current number of bots, oncaller got paged, decrease the percentage to 20% to observe the bots status. Bug: 1202631 Change-Id: I61d2e8fc4495ebdd7dfc1cc37d8c96bbbe5ab89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3002043 Commit-Queue: Jieting Yang <[email protected]> Reviewed-by: Yuke Liao <[email protected]> Reviewed-by: Stephanie Kim <[email protected]> Cr-Commit-Position: refs/heads/master@{#897857}
Bug: 1217405 Change-Id: Idc8936d237e5223a8d027a955715f200a9615670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3000828 Auto-Submit: Mitsuru Oshima <[email protected]> Commit-Queue: Mitsuru Oshima <[email protected]> Commit-Queue: Scott Violet <[email protected]> Reviewed-by: Scott Violet <[email protected]> Cr-Commit-Position: refs/heads/master@{#897858}
These fail to build for me locally. Maybe they do not have sufficient bot coverage. Change-Id: Iebd509317b233c4ed6139e4ff3d956411c1ae74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2998183 Reviewed-by: Brian Malcolm <[email protected]> Commit-Queue: Lei Zhang <[email protected]> Cr-Commit-Position: refs/heads/master@{#897859}
In preparation to adding StorageKey to ServiceWorkerRegistration's constructor pipe it into the ServiceWorkerRegistry. Bug: 1199077 Change-Id: Ie99c43bc223764429d43ba06deb6188203fd7701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2995762 Commit-Queue: Steven Bingler <[email protected]> Reviewed-by: Ben Kelly <[email protected]> Cr-Commit-Position: refs/heads/master@{#897860}
https://webrtc.googlesource.com/src.git/+log/fbdd77889119..c0a4a09faef2 2021-07-01 [email protected] Use default NetEq config for simulation in event log visualizer. 2021-07-01 [email protected] Prepare WebRtcVideoReceiveStream for configuration changes. 2021-07-01 [email protected] Implement nack_count metric for inbound audio rtp streams. 2021-07-01 [email protected] Delete unneeded references to string_encode.h 2021-07-01 [email protected] Update peerconnection example to not use Win32SocketServer 2021-07-01 [email protected] Add jitterBufferDelay and jitterBufferEmittedCount stats for video 2021-07-01 [email protected] Add bionic mb builder config 2021-07-01 [email protected] Update WebRTC code version (2021-07-01T04:09:57). 2021-07-01 [email protected] openssl: Use unique_ptr to remove unnecessary goto statements from openssl_adapter 2021-06-30 [email protected] Fix CPD upload script --input-results-file description 2021-06-30 [email protected] Fix -Wunreachable-code-aggressive. 2021-06-30 [email protected] video_replay: use abseil uint32_t for ssrc and ssrc_rtx 2021-06-30 [email protected] Fix the last checksum 2021-06-30 [email protected] Add ARM64 for min expected PSNR score for the M1 Mac. 2021-06-30 [email protected] Add M1 Mac expected results for AudioDecoderIsacFixTest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1066980,chromium:1206432 Tbr: [email protected] Change-Id: Iedd7cd5fae6d58b3284aa4e40ce8b6551fb52277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3000848 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/master@{#897861}
Bug: 1223773 No-Try: true Change-Id: I6d6b348fc00d28acdf0b7cc6e610f8bb8348db19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3001415 Owners-Override: Matthew Wolenetz <[email protected]> Auto-Submit: Matthew Wolenetz <[email protected]> Reviewed-by: Dan Sanders <[email protected]> Commit-Queue: Dan Sanders <[email protected]> Cr-Commit-Position: refs/heads/master@{#897862}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.