Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perk p2 single #25

Closed
wants to merge 76 commits into from
Closed

Conversation

warisa-r
Copy link

@warisa-r warisa-r commented Mar 7, 2024

Hello,

I hope you are having a nice day!

I have created this new branch without p3 content and added the elixir to this file https://github.com/trixi-framework/Trixi.jl/blob/main/test/test_tree_1d_advection.jl like you instructed. Please let me know if I misunderstood or missed something.

Copy link

github-actions bot commented Mar 7, 2024

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Copy link
Owner

@DanielDoehring DanielDoehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Warisa, Thanks four your work!

We should provide a functionality such that the user can send in a list of eigenvalues, see the comments. In case of questions contact me on Slack!

examples/structured_1d_dgsem/elixir_burgers_PERK3.jl Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
examples/tree_1d_dgsem/elixir_advection_PERK2.jl Outdated Show resolved Hide resolved
examples/tree_1d_dgsem/elixir_advection_PERK2.jl Outdated Show resolved Hide resolved
src/Trixi.jl Outdated Show resolved Hide resolved
@warisa-r
Copy link
Author

Close this one for now. Working on making Convex and ECOS extensions rather than direct dependencies.

@warisa-r warisa-r closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants