forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add issue template for feature gate tracking issues (solana-labs#24040)
* Add issue template for feature gate tracking issues * review feedback
- Loading branch information
Showing
4 changed files
with
84 additions
and
15 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
name: General Issue | ||
about: Create a report describing a problem and a proposed solution | ||
title: '' | ||
assignees: '' | ||
--- | ||
|
||
#### Problem | ||
|
||
|
||
|
||
#### Proposed Solution |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
name: Feature Gate Tracker | ||
description: Track the development and status of an on-chain feature | ||
title: "Feature Gate: " | ||
labels: ["feature-gate"] | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: > | ||
Steps to add a new feature are outlined below. Note that these steps only cover | ||
the process of getting a feature into the core Solana code. | ||
- For features that are unambiguously good (ie bug fixes), these steps are sufficient. | ||
- For features that should go up for community vote (ie fee structure changes), more | ||
information on the additional steps to follow can be found at: | ||
<https://spl.solana.com/feature-proposal#feature-proposal-life-cycle> | ||
1. Generate a new keypair with `solana-keygen new --outfile feature.json --no-passphrase` | ||
- Keypairs should be held by core contributors only. If you're a non-core contirbutor going | ||
through these steps, the PR process will facilitate a keypair holder being picked. That | ||
person will generate the keypair, provide pubkey for PR, and ultimately enable the feature. | ||
2. Add a public module for the feature, specifying keypair pubkey as the id with | ||
`solana_sdk::declare_id!()` within the module. Additionally, add an entry to `FEATURE_NAMES` map. | ||
3. Add desired logic to check for and switch on feature availability. | ||
- type: textarea | ||
id: description | ||
attributes: | ||
label: Description | ||
placeholder: Describe why the new feature gate is needed and any necessary conditions for its activation | ||
validations: | ||
required: true | ||
- type: input | ||
id: id | ||
attributes: | ||
label: Feature ID | ||
description: The public key of the feature account | ||
validations: | ||
required: true | ||
- type: dropdown | ||
id: activation-method | ||
attributes: | ||
label: Activation Method | ||
options: | ||
- Single Core Contributor | ||
- Staked Validator Vote | ||
validations: | ||
required: true | ||
- type: input | ||
id: testnet | ||
attributes: | ||
label: Testnet Activation Epoch | ||
placeholder: Edit this response when feature is activated on this cluster | ||
validations: | ||
required: false | ||
- type: input | ||
id: devnet | ||
attributes: | ||
label: Devnet Activation Epoch | ||
placeholder: Edit this response when feature is activated on this cluster | ||
validations: | ||
required: false | ||
- type: input | ||
id: mainnet-beta | ||
attributes: | ||
label: Mainnet-Beta Activation Epoch | ||
placeholder: Edit this response when feature is activated on this cluster | ||
validations: | ||
required: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,9 @@ | ||
#### Problem | ||
|
||
|
||
|
||
<!-- OPTIONAL --> | ||
<!-- Any changes that affect the behavior of a feature activation MUST add the feature-gate label and include details --> | ||
#### Feature Gate Details | ||
<!-- Describe why the new or modified feature gate is needed and any necessary conditions for its activation --> | ||
|
||
|
||
|
||
#### Summary of Changes | ||
|
||
|
||
|
||
Fixes # | ||
<!-- OPTIONAL: Feature Gate Issue: # --> | ||
<!-- Don't forget to add the "feature-gate" label --> |