Bring back TPM PPI in RAM #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Żygowski <[email protected]>
This reverts commit 4625e69.
Certain platform like VP2410 can not keep RAM contents between reboots which results in TPM PPI to not work. Add an option to let platform use UEFI variable backed TPM PPI. It will let firmware menu PPI requests to be processed properly at the cost of not working OS runtime PPI requests which did not work anyway. Signed-off-by: Michał Żygowski <[email protected]>
|
@mkopec ping |
mkopec
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more flushes and a stall before reset to get the flush or wbinvd hit the RAM.
Now with the VP66xx power cycles fixed: Dasharo/dasharo-blobs#31 RAM backed for PPI works on VP6670 (the power cycle fix was not enough, the flushes in this PR are required as well). Similar fixes landed for VP32xx and VP2430 and the TPM PPI in RAM works there too.
Tested also on VP2410, where RAM backed did not want to work too. Unfortunately still doesn't work, even when request is sent from OS. The memory content of TPM PPI area looks random.