Custom fan curve test fails #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue is on commit 95f5dee |
|
@mkopec some old PR, is it possible still to review it? Seems not so invasive |
mkopec
approved these changes
Dec 2, 2024
mkopec
force-pushed
the
custom-fan-curve-test-fails
branch
from
aedf89f to
f02ac78
Compare
We don't have an OS driver to expose the fan speed Signed-off-by: Filip Gołaś <[email protected]>
mkopec
force-pushed
the
custom-fan-curve-test-fails
branch
from
f02ac78 to
053c95c
Compare
|
Thank you @mkopec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#336
NovaCustom laptops should not support it - change configs
The test may be faulty - look into that