-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Beta parameter in GR percolation #158
FIX: Beta parameter in GR percolation #158
Conversation
- The beta parameters in GR production in time step dependent. Currently, beta was assigned to the daily time step value (i.e., 9/4) This commit adds a beta parameter which is time step dependent. The hydrological module concerned by this modification are ``gr4``, ``gr5`` and ``loieau`` - This modifications impacted the test. A new baseline has been generated. The setup of the tests on mutliset estimate has been changed to overcome warning when dividing by zero. - The docstring has been updated
@nghi-truyen, il y a une erreur avec le test sur multiset estimate. J'ai du changer ce test parce qu'en modifiant la valeur de beta pour la percolation, le test renvoyait une erreur avec une division par zero de |
Ah oui, ça peut arriver, ça ne me surprend pas. C'est juste que la taille des samples est trop petite, donc cette erreur peut survenir. Je pense que la solution qui est moins coûteuse serait d'essayer de changer le random_state, sinon il faudra augmenter la taille des samples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finalement !
Yes :3. Pas tjs simple de changer pas grand chose |
@inoelloc Aller je le merge pour pouvoir lancer les calculs avec le nouveau calcul de beta. |
The beta parameter in GR production is time step dependent. Currently, beta was assigned to the daily time step value (i.e.,
9/4
) This commit adds a beta parameter which is time step dependent. The hydrological module concerned by this modification aregr4
,gr5
andloieau
This modification impacted the test. A new baseline has been generated. The setup of the tests on mutliset estimate has been changed to overcome warning when dividing by zero.
The docstring has been updated