Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exponential store gr6 #210

Merged
merged 41 commits into from
Jul 26, 2024
Merged

Exponential store gr6 #210

merged 41 commits into from
Jul 26, 2024

Conversation

asjeb
Copy link
Collaborator

@asjeb asjeb commented Jun 12, 2024

Exponential reservoir inspired by airGR : https://hydrogr.github.io/airGR/

@asjeb asjeb linked an issue Jun 12, 2024 that may be closed by this pull request
ENH: Add GR6 hydrological module #179
Closed
@asjeb asjeb added the enhancement New feature or request label Jun 12, 2024
@asjeb asjeb self-assigned this Jun 12, 2024
@asjeb asjeb added this to the Release v1.1.0 milestone Jun 12, 2024
@inoelloc inoelloc requested review from inoelloc and pag13 June 14, 2024 09:52
inoelloc
inoelloc reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@inoelloc inoelloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voilà à toi. Je n'ai pas mis de commentaire sur toutes les modifications si ca se répétait.

doc/source/math_num_documentation/forward_structure.rst Outdated Show resolved Hide resolved
doc/source/math_num_documentation/forward_structure.rst Outdated Show resolved Hide resolved
doc/source/user_guide/index.rst Outdated Show resolved Hide resolved
doc/source/user_guide/others/gr6.rst Outdated Show resolved Hide resolved
doc/source/math_num_documentation/forward_structure.rst Outdated Show resolved Hide resolved
doc/source/user_guide/others/gr6.rst Outdated Show resolved Hide resolved
doc/source/user_guide/others/gr6.rst Outdated Show resolved Hide resolved
smash/fcore/operator/md_gr_operator.f90 Outdated Show resolved Hide resolved
smash/fcore/operator/md_gr_operator.f90 Outdated Show resolved Hide resolved
smash/_constant.py Outdated Show resolved Hide resolved
asjeb and others added 9 commits July 22, 2024 09:09
@asjeb @inoelloc
Update doc/source/math_num_documentation/forward_structure.rst
1850e52 
Co-authored-by: Francois Colleoni <[email protected]>
@asjeb @inoelloc
Update doc/source/user_guide/index.rst
c1c400c 
Co-authored-by: Francois Colleoni <[email protected]>
@asjeb @inoelloc
Update doc/source/math_num_documentation/forward_structure.rst
baab1bd 
Co-authored-by: Francois Colleoni <[email protected]>
@asjeb @inoelloc
Update smash/fcore/operator/md_gr_operator.f90
7bc573c 
Co-authored-by: Francois Colleoni <[email protected]>
@asjeb @inoelloc
Update smash/fcore/operator/md_gr_operator.f90
ff9323e 
Co-authored-by: Francois Colleoni <[email protected]>
change name of caracteristic time
87f3f69
Merge branch 'exponential_store_GR6' of github.com:DassHydro-dev/smas…
0a5db1d 
…h into exponential_store_GR6
Merge branch 'main' into exponential_store_GR6
2801a2f
fixed names
ad8b230
nghi-truyen
nghi-truyen reviewed Jul 22, 2024
View reviewed changes
smash/fcore/operator/md_gr_operator.f90 Outdated Show resolved Hide resolved
smash/tests/test_constant.py Outdated Show resolved Hide resolved
@asjeb
Copy link
Collaborator Author

asjeb commented Jul 24, 2024

Je pense être arrivée difficilement au bout de cette PR.
Il y a un meilleur nom à trouver pour le paramètre de décrue que j'ai renommé te. le ne me convient pas trop car cela me fait penser au lexc...

@asjeb asjeb requested review from inoelloc and nghi-truyen July 24, 2024 10:50
nghi-truyen
nghi-truyen reviewed Jul 24, 2024
View reviewed changes
doc/source/user_guide/others/cance_gr6.rst Outdated Show resolved Hide resolved
doc/source/user_guide/index.rst Outdated Show resolved Hide resolved
smash/fcore/operator/md_gr_operator.f90 Outdated Show resolved Hide resolved
asjeb and others added 3 commits July 24, 2024 14:54
@nghi-truyen nghi-truyen self-requested a review July 24, 2024 13:23
nghi-truyen
nghi-truyen requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@nghi-truyen nghi-truyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est bon pour moi et je laisse François approuver si c'est ok pour lui

inoelloc
inoelloc reviewed Jul 24, 2024
View reviewed changes
doc/source/math_num_documentation/forward_structure.rst Show resolved Hide resolved
smash/_constant.py Outdated Show resolved Hide resolved
smash/_constant.py Outdated Show resolved Hide resolved
smash/_constant.py Outdated Show resolved Hide resolved
smash/tests/diff_baseline.csv Outdated Show resolved Hide resolved
smash/tests/test_constant.py Outdated Show resolved Hide resolved
@asjeb asjeb requested a review from inoelloc July 25, 2024 12:31
@asjeb
Copy link
Collaborator Author

asjeb commented Jul 25, 2024

Changement de nom t_e -> b_e fait.

inoelloc
inoelloc approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@inoelloc inoelloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Au dernier détail pres, tout bon pour moi ! Merci !

doc/source/math_num_documentation/forward_structure.rst Outdated Show resolved Hide resolved
@asjeb
Copy link
Collaborator Author

asjeb commented Jul 26, 2024

Ah oui j'en avais oublié un ! Il y a un T_e dans la présentation du module de neige, donc j'ai préféré le faire à la main dans la doc.
Merci à vous deux

@nghi-truyen nghi-truyen merged commit f5e0ae8 into main Jul 26, 2024
22 checks passed
@nghi-truyen nghi-truyen deleted the exponential_store_GR6 branch July 26, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghi-truyen nghi-truyen nghi-truyen approved these changes

@inoelloc inoelloc inoelloc approved these changes

@pag13 pag13 Awaiting requested review from pag13

Assignees

@asjeb asjeb

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release v1.1.0
Development

Successfully merging this pull request may close these issues.

ENH: Add GR6 hydrological module
4 participants
@asjeb @inoelloc @pag13 @nghi-truyen