Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grc structure (model for reunion) #343

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Fix grc structure (model for reunion) #343

merged 6 commits into from
Nov 20, 2024

Conversation

maximejay
Copy link
Collaborator

Fix grc structure (model for reunion). remove leaking from slow tranfert reservoir cl, because the model calibration was done with this structure.
Please add this to the next 1.1 realease

…fert reservoir cl, because the model calibration was done with this structure
@maximejay maximejay added the bug Something isn't working label Nov 13, 2024
@maximejay maximejay added this to the Release v1.1.0 milestone Nov 13, 2024
@inoelloc
Copy link
Contributor

Il manque juste à modifier le svg de la structure grc https://github.com/DassHydro/smash/blob/main/doc/source/_static/grc_structure.svg

@asjeb asjeb merged commit 1d1483a into main Nov 20, 2024
22 checks passed
@nghi-truyen
Copy link
Member

Il faudrait changer aussi grc_mlp suite à ce changement..

@nghi-truyen nghi-truyen deleted the fix_grc_time_step branch November 20, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants