Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icons in README by using old version as source #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebkur
Copy link

@sebkur sebkur commented Oct 16, 2024

The Windows icon has been removed in a recent version of simple icons, but it can still be obtained from older versions of the library on some of the CDNs.

The Windows icon has been removed in a recent version of simple icons,
but it can still be obtained from older versions of the library on some
of the CDNs.
@sebkur
Copy link
Author

sebkur commented Oct 16, 2024

Screenshot from 2024-10-16 10-59-30

^- this just makes the project look so abandoned on first sight.

@sebkur
Copy link
Author

sebkur commented Oct 16, 2024

This is a workaround for this: simple-icons/simple-icons#10019

Copy link
Owner

@DatL4g DatL4g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sources do not support dark mode, which is widely used on GitHub.

Are there white/black equivalents? Then we could specify these by attribute.

@sebkur
Copy link
Author

sebkur commented Oct 16, 2024

Oh, I didn't realize that feature of simple-icons own CDN was in use here. Hmm, unfortunately, the other CDNs don't seem to support this. Thinking about other workarounds, but cannot seem to find any at the moment. Sorry, don't have a solution for this then, feel free to close...

@sebkur
Copy link
Author

sebkur commented Oct 18, 2024

I've been looking around a bit and found out that there are ways to include html in github markdown and it's even possible to select images based on the dark/light theme: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to

So it's possible to exchange the image based on theme, here's some experimental code: sebkur@c4418d9 visible at https://github.com/sebkur/KCEF/tree/fix-icons2

In the example for the sake of trying things out, I'm using the windows icon for light mode and the linux icon for dark mode. That works. So if we had a source of each image with white fill, we could swap them out based on the theme. But that's the problem of course, we don't have that...

It's interesting though, the SVG files don actually specify an fill color, so they default to black. It's even possible to use some css in the embedded html, however it does not look like we can manipulate the svg coloring from the embedding html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants