Fix for --format provider-json when run with google-batch provider

[pgm]

A fix for a very minor issue where running dsub --provider google-batch ... --format provider-json was resulting in the following exception:

Traceback (most recent call last):
  File "/opt/homebrew/Caskroom/miniconda/base/envs/dsub/bin/dstat", line 33, in <module>
    sys.exit(load_entry_point('dsub', 'console_scripts', 'dstat')())
  File "/Users/pmontgom/dev/dsub/dsub/commands/dstat.py", line 224, in main
    formatter.prepare_and_print_table(rows, args.summary)
  File "/Users/pmontgom/dev/dsub/dsub/lib/output_formatter.py", line 80, in prepare_and_print_table
    row = self.prepare_output(row)
  File "/Users/pmontgom/dev/dsub/dsub/lib/output_formatter.py", line 60, in prepare_output
    if col in row:
  File "/opt/homebrew/Caskroom/miniconda/base/envs/dsub/lib/python3.10/site-packages/proto/message.py", line 688, in __contains__
    pb_value = getattr(self._pb, key)
AttributeError: last-update

Tried to create a fix, which not particularly elegant, makes minimal changes.

Happy to take feedback if you think it'd be better fixed a different way.

Thanks.

[wnojopra]

Thanks (again!) for the PR, @pgm! Yea, this particular dstat format has been neglected so far for the google-batch provider. It's great that you've found a quick fix for it. I myself have been working on finishing dstat implementation for Batch and getting the e2e_dstat.sh test passing.

And then a few points on dsub's current PR acceptance policy:

• First and most importantly, thank you for the PR. We very much appreciate community support.
• Currently, the "source of truth" for dsub source code is in an internal repo. We won't be able to merge this PR directly. What we can do however is take it, add it to our internal system, and then acknowledge your contributions when it is shared back out to this repo.
• We are looking into ways to update our contribution acceptance policy so that we can directly merge PRs from the community.

[wnojopra]

Hi @pgm!

As mentioned in our CONTRIBUTING doc, contributions to dsub must be accompanied by a Contributor License Agreement. Please review and sign our Contributor License Agreement and send it to our IP team at [email protected].

Thanks!

[pgm]

Ah! Thanks for pointing out the CONTRIBUTING.md doc. I quickly glanced through the README for guidance on PRs but didn't look carefully enough to discover that doc. I stumbled upon the exception when I was testing things and it was easy to fix, so I thought I'd pass it along in case it was helpful, but feel free to do with it however you wish. Thanks for your very supportive responses. Phil

…

On Wed, Sep 4, 2024 at 2:51 PM Willy Nojopranoto ***@***.***> wrote: Hi @pgm <https://github.com/pgm>! As mentioned in our CONTRIBUTING doc <https://github.com/DataBiosphere/dsub/blob/main/CONTRIBUTING.md>, contributions to dsub must be accompanied by a Contributor License Agreement. Please review and sign our Contributor License Agreement <https://docs.google.com/document/d/1Yc-z59DQKRqiqpVgHcIHC3xhfwm3DoPmpc9eFwr_J8c/edit> and send it to our IP team at ***@***.*** Thanks! — Reply to this email directly, view it on GitHub <#297 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACSUVT46CAYKSR5U2HH7LZU5JBPAVCNFSM6AAAAABNLS46R6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZG42TMMBWHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>