[DCJ-400-gradle] Upgrade io.swagger.codegen.v3 deps 3.0.61 -> 3.0.62 #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch upgrade without changing configuration caused compilation of Swagger generated code to fail with the following errors:
```
/github/workspace/build/generated-src/swagger/src/main/java/bio/terra/model/ResourcePolicyModel.java:10: error: package io.swagger.configuration does not exist
import io.swagger.configuration.NotUndefined;
^
/github/workspace/build/generated-src/swagger/src/main/java/bio/terra/model/ResourcePolicyModel.java:21: error: cannot find symbol
@notundefined
^
```
For now, setting `validationMode=legacy` but think this might be another bug in swagger-codegen-generators.
Patch upgrades have lately included breaking changes. But, we do want to keep swagger-codegen and swagger-codegen-cli versions in sync with each other, so introduce a new dependency grouping for them.
|
okotsopoulos
requested review from
rushtong and
fboulnois
and removed request for
a team
fboulnois
approved these changes
Sep 4, 2024
okotsopoulos
deleted the
okotsopo-DCJ-400-io.swagger.codegen.v3-3.0.62
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/DCJ-400
Addresses
This patch upgrade without changing configuration caused compilation of Swagger generated code to fail with the following errors:
This was introduced in swagger-api/swagger-codegen-generators#1308
Summary of changes
io.swagger.codegen.v3:swagger-codegenandio.swagger.codegen.v3:swagger-codegen-clifrom 3.0.61 -> 3.0.62validationMode=legacyalong with these patch upgrades to mitigate another likely bug in swagger-codegen-generators.io.swagger.codegen.v3patch upgrades have lately included breaking changes, exclude them from our grouped minor and patch upgrade Dependabot PRs. Any available upgrades will be PRed separately.Testing Strategy
CI build and tests should pass.