Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PF-2983]: Bump com.google.apis:google-api-services-logging from v2-rev20250124-2.0.0 to v2-rev20250207-2.0.0 #225

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 1, 2025

Bumps com.google.apis:google-api-services-logging from v2-rev20250124-2.0.0 to v2-rev20250207-2.0.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps com.google.apis:google-api-services-logging from v2-rev20250124-2.0.0 to v2-rev20250207-2.0.0.

---
updated-dependencies:
- dependency-name: com.google.apis:google-api-services-logging
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested review from a team, pshapiro4broad and mmorgantaylor and removed request for a team March 1, 2025 11:31
Copy link

sonarqubecloud bot commented Mar 1, 2025

@mmorgantaylor
Copy link
Contributor

@pshapiro4broad I'm confused by the version semantics (the date was updated but 2.0.0 stayed the same), and I can't find a changelog for this update. Mostly I'm grumpy at google about this, but it's probably ok to update?

@pshapiro4broad
Copy link
Member

@mmorgantaylor I think this is a problem we made for ourselves. There is are higher level APIs (aka "google cloud APIs") which are provided by the google BOM and aren't versioned separately. But instead we are using the lower level APIs (aka "google client APIs") instead, which is versioned separately (and is not semver?). As I understand it, the cloud APIs lag behind the client APIs, so maybe there was some feature we needed which the cloud APIs didn't have.

In terms of this change, the only use of this dependency that I can see is in RequestLoggingFilter, and it's only used to build a HttpRequest object which creates a JSON payload for the logs. So it seems pretty safe to me, if RequestLoggingFilter still compiles.

@mmorgantaylor
Copy link
Contributor

@pshapiro4broad thanks, all sounds right to me!

@mmorgantaylor mmorgantaylor merged commit 40bcbd0 into develop Mar 3, 2025
3 checks passed
@mmorgantaylor mmorgantaylor deleted the dependabot/gradle/develop/com.google.apis-google-api-services-logging-v2-rev20250207-2.0.0 branch March 3, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants