-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [RUM-3598] Ignore collecting requests to logs PCI intake as RUM resources #2655
🐛 [RUM-3598] Ignore collecting requests to logs PCI intake as RUM resources #2655
Conversation
Bundles Sizes Evolution
|
7662e7d
to
ae82cd2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2655 +/- ##
=======================================
Coverage 92.91% 92.92%
=======================================
Files 239 239
Lines 6931 6937 +6
Branches 1517 1518 +1
=======================================
+ Hits 6440 6446 +6
Misses 491 491 ☔ View full report in Codecov by Sentry. |
ae82cd2
to
9407d23
Compare
packages/core/src/domain/configuration/transportConfiguration.ts
Outdated
Show resolved
Hide resolved
packages/core/src/domain/configuration/transportConfiguration.ts
Outdated
Show resolved
Hide resolved
packages/core/src/domain/configuration/transportConfiguration.ts
Outdated
Show resolved
Hide resolved
packages/core/src/domain/configuration/transportConfiguration.ts
Outdated
Show resolved
Hide resolved
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 34m) Use |
❌ MergeQueue Build pipeline has failing jobs for f02eb2b Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. You should have a look at the pipeline, wait for the build to finish and investigate the failures.
|
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 34m) Use |
❌ MergeQueue Build pipeline has failing jobs for 1653547 Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. You should have a look at the pipeline, wait for the build to finish and investigate the failures.
|
Motivation
Requests to PCI compliant endpoint are captured by RUM as resources, while they shouldn't be.
Changes
RUM initialisation doesn't have access to Logs config. Thus, PCI endpoint requests are not skipped and are captured as RUM resources.
When the provided site is
datadoghq.com
, push PCI intake url to the intake prefixes used to ignore resourcesTesting
I have gone over the contributing documentation.