Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUM-3598] Ignore collecting requests to logs PCI intake as RUM resources #2655

Conversation

N-Boutaib
Copy link
Contributor

@N-Boutaib N-Boutaib commented Mar 18, 2024

Motivation

Requests to PCI compliant endpoint are captured by RUM as resources, while they shouldn't be.

Changes

RUM initialisation doesn't have access to Logs config. Thus, PCI endpoint requests are not skipped and are captured as RUM resources.

When the provided site is datadoghq.com, push PCI intake url to the intake prefixes used to ignore resources

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Copy link

cit-pr-commenter bot commented Mar 18, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫%
Rum 155.94 kB 156.03 kB +0.06%
Logs 55.15 kB 55.24 kB +0.16%
Rum Slim 101.53 kB 101.61 kB +0.08%
Worker 25.21 kB 25.21 kB 0.00%

@N-Boutaib N-Boutaib changed the title [RUM] Ignore collecting requests to logs PCI intake as RUM resources [RUM-3598] Ignore collecting requests to logs PCI intake as RUM resources Mar 18, 2024
@N-Boutaib N-Boutaib force-pushed the najib.boutaib/ignore-collecting-pci-intake-requests-as-rum-resources branch from 7662e7d to ae82cd2 Compare March 18, 2024 15:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (cdcd13d) to head (07da283).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2655   +/-   ##
=======================================
  Coverage   92.91%   92.92%           
=======================================
  Files         239      239           
  Lines        6931     6937    +6     
  Branches     1517     1518    +1     
=======================================
+ Hits         6440     6446    +6     
  Misses        491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@N-Boutaib N-Boutaib force-pushed the najib.boutaib/ignore-collecting-pci-intake-requests-as-rum-resources branch from ae82cd2 to 9407d23 Compare March 18, 2024 15:59
@N-Boutaib N-Boutaib changed the title [RUM-3598] Ignore collecting requests to logs PCI intake as RUM resources 🐛 [RUM-3598] Ignore collecting requests to logs PCI intake as RUM resources Mar 20, 2024
@N-Boutaib N-Boutaib marked this pull request as ready for review March 20, 2024 13:58
@N-Boutaib N-Boutaib requested a review from a team as a code owner March 20, 2024 13:58
@N-Boutaib
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Mar 21, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 34m)

Use /merge -c to cancel this operation!

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Mar 21, 2024

❌ MergeQueue

Build pipeline has failing jobs for f02eb2b

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected before the end of the pipeline.

You should have a look at the pipeline, wait for the build to finish and investigate the failures.
When you are ready, re-add your pull request to the queue!

⚠️ Do NOT retry failed jobs directly.

They were executed on a temporary branch created by the merge queue. If you retry them, they are going to fail because the branch no longer exists.

Details

List of failed jobs:

Go to failed Gitlab pipeline.

If you need support, contact us on Slack #ci-interfaces with those details!

@N-Boutaib
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Mar 21, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 34m)

Use /merge -c to cancel this operation!

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Mar 21, 2024

❌ MergeQueue

Build pipeline has failing jobs for 1653547

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected before the end of the pipeline.

You should have a look at the pipeline, wait for the build to finish and investigate the failures.
When you are ready, re-add your pull request to the queue!

⚠️ Do NOT retry failed jobs directly.

They were executed on a temporary branch created by the merge queue. If you retry them, they are going to fail because the branch no longer exists.

Details

List of failed jobs:

Go to failed Gitlab pipeline.

If you need support, contact us on Slack #ci-interfaces with those details!

@N-Boutaib N-Boutaib merged commit 7f9811f into main Mar 21, 2024
17 of 18 checks passed
@N-Boutaib N-Boutaib deleted the najib.boutaib/ignore-collecting-pci-intake-requests-as-rum-resources branch March 21, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants