Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO-NOT-MERGE][AGENTRUN-107] Update to go 1.24.0 #34011

Closed
wants to merge 7 commits into from

Conversation

pgimalac
Copy link
Member

What does this PR do?

Update Go to 1.24.0.

Motivation

Testing, checking if there is an impact on performance.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 13, 2025

Gitlab CI Configuration Changes

Modified Jobs

variables (configuration)
  variables:
    AGENT_API_KEY_ORG2: agent-api-key-org-2
    AGENT_APP_KEY_ORG2: agent-ci-app-key-org-2
    AGENT_BINARIES_DIR: bin/agent
    AGENT_GITHUB_APP: agent-github-app
    AGENT_QA_E2E: agent-qa-e2e
    API_KEY_ORG2: ci.datadog-agent.datadog_api_key_org2
    ARTIFACT_DOWNLOAD_ATTEMPTS: 2
    ATLASSIAN_WRITE: atlassian-write
    BTFHUB_ARCHIVE_BRANCH: main
    BUCKET_BRANCH: dev
    CHANGELOG_COMMIT_SHA: ci.datadog-agent.gitlab_changelog_commit_sha
    CHOCOLATEY_API_KEY: ci.datadog-agent.chocolatey_api_key
-   CI_IMAGE_BTF_GEN: v55750746-d62c2509
?                          ^^^    ------
+   CI_IMAGE_BTF_GEN: v55781556-f181d356
?                         ++ ^  ++++ ++
-   CI_IMAGE_BTF_GEN_SUFFIX: ''
?                            ^^
+   CI_IMAGE_BTF_GEN_SUFFIX: _test_only
?                            ^^^^^^^^^^
-   CI_IMAGE_DD_AGENT_TESTING: v55750746-d62c2509
?                                   ^^^    ------
+   CI_IMAGE_DD_AGENT_TESTING: v55781556-f181d356
?                                  ++ ^  ++++ ++
-   CI_IMAGE_DD_AGENT_TESTING_SUFFIX: ''
?                                     ^^
+   CI_IMAGE_DD_AGENT_TESTING_SUFFIX: _test_only
?                                     ^^^^^^^^^^
-   CI_IMAGE_DEB_ARM64: v55750746-d62c2509
?                            ^^^    ------
+   CI_IMAGE_DEB_ARM64: v55781556-f181d356
?                           ++ ^  ++++ ++
-   CI_IMAGE_DEB_ARM64_SUFFIX: ''
?                              ^^
+   CI_IMAGE_DEB_ARM64_SUFFIX: _test_only
?                              ^^^^^^^^^^
-   CI_IMAGE_DEB_ARMHF: v55750746-d62c2509
?                            ^^^    ------
+   CI_IMAGE_DEB_ARMHF: v55781556-f181d356
?                           ++ ^  ++++ ++
-   CI_IMAGE_DEB_ARMHF_SUFFIX: ''
?                              ^^
+   CI_IMAGE_DEB_ARMHF_SUFFIX: _test_only
?                              ^^^^^^^^^^
-   CI_IMAGE_DEB_X64: v55750746-d62c2509
?                          ^^^    ------
+   CI_IMAGE_DEB_X64: v55781556-f181d356
?                         ++ ^  ++++ ++
-   CI_IMAGE_DEB_X64_SUFFIX: ''
?                            ^^
+   CI_IMAGE_DEB_X64_SUFFIX: _test_only
?                            ^^^^^^^^^^
-   CI_IMAGE_DOCKER_ARM64: v55750746-d62c2509
?                               ^^^    ------
+   CI_IMAGE_DOCKER_ARM64: v55781556-f181d356
?                              ++ ^  ++++ ++
-   CI_IMAGE_DOCKER_ARM64_SUFFIX: ''
?                                 ^^
+   CI_IMAGE_DOCKER_ARM64_SUFFIX: _test_only
?                                 ^^^^^^^^^^
-   CI_IMAGE_DOCKER_X64: v55750746-d62c2509
?                             ^^^    ------
+   CI_IMAGE_DOCKER_X64: v55781556-f181d356
?                            ++ ^  ++++ ++
-   CI_IMAGE_DOCKER_X64_SUFFIX: ''
?                               ^^
+   CI_IMAGE_DOCKER_X64_SUFFIX: _test_only
?                               ^^^^^^^^^^
-   CI_IMAGE_GITLAB_AGENT_DEPLOY: v55750746-d62c2509
?                                      ^^^    ------
+   CI_IMAGE_GITLAB_AGENT_DEPLOY: v55781556-f181d356
?                                     ++ ^  ++++ ++
-   CI_IMAGE_GITLAB_AGENT_DEPLOY_SUFFIX: ''
?                                        ^^
+   CI_IMAGE_GITLAB_AGENT_DEPLOY_SUFFIX: _test_only
?                                        ^^^^^^^^^^
-   CI_IMAGE_LINUX_GLIBC_2_17_X64: v55750746-d62c2509
?                                       ^^^    ------
+   CI_IMAGE_LINUX_GLIBC_2_17_X64: v55781556-f181d356
?                                      ++ ^  ++++ ++
-   CI_IMAGE_LINUX_GLIBC_2_17_X64_SUFFIX: ''
?                                         ^^
+   CI_IMAGE_LINUX_GLIBC_2_17_X64_SUFFIX: _test_only
?                                         ^^^^^^^^^^
-   CI_IMAGE_LINUX_GLIBC_2_23_ARM64: v55750746-d62c2509
?                                         ^^^    ------
+   CI_IMAGE_LINUX_GLIBC_2_23_ARM64: v55781556-f181d356
?                                        ++ ^  ++++ ++
-   CI_IMAGE_LINUX_GLIBC_2_23_ARM64_SUFFIX: ''
?                                           ^^
+   CI_IMAGE_LINUX_GLIBC_2_23_ARM64_SUFFIX: _test_only
?                                           ^^^^^^^^^^
-   CI_IMAGE_RPM_ARM64: v55750746-d62c2509
?                            ^^^    ------
+   CI_IMAGE_RPM_ARM64: v55781556-f181d356
?                           ++ ^  ++++ ++
-   CI_IMAGE_RPM_ARM64_SUFFIX: ''
?                              ^^
+   CI_IMAGE_RPM_ARM64_SUFFIX: _test_only
?                              ^^^^^^^^^^
-   CI_IMAGE_RPM_ARMHF: v55750746-d62c2509
?                            ^^^    ------
+   CI_IMAGE_RPM_ARMHF: v55781556-f181d356
?                           ++ ^  ++++ ++
-   CI_IMAGE_RPM_ARMHF_SUFFIX: ''
?                              ^^
+   CI_IMAGE_RPM_ARMHF_SUFFIX: _test_only
?                              ^^^^^^^^^^
-   CI_IMAGE_RPM_X64: v55750746-d62c2509
?                          ^^^    ------
+   CI_IMAGE_RPM_X64: v55781556-f181d356
?                         ++ ^  ++++ ++
-   CI_IMAGE_RPM_X64_SUFFIX: ''
?                            ^^
+   CI_IMAGE_RPM_X64_SUFFIX: _test_only
?                            ^^^^^^^^^^
-   CI_IMAGE_SYSTEM_PROBE_ARM64: v55750746-d62c2509
?                                     ^^^    ------
+   CI_IMAGE_SYSTEM_PROBE_ARM64: v55781556-f181d356
?                                    ++ ^  ++++ ++
-   CI_IMAGE_SYSTEM_PROBE_ARM64_SUFFIX: ''
?                                       ^^
+   CI_IMAGE_SYSTEM_PROBE_ARM64_SUFFIX: _test_only
?                                       ^^^^^^^^^^
-   CI_IMAGE_SYSTEM_PROBE_X64: v55750746-d62c2509
?                                   ^^^    ------
+   CI_IMAGE_SYSTEM_PROBE_X64: v55781556-f181d356
?                                  ++ ^  ++++ ++
-   CI_IMAGE_SYSTEM_PROBE_X64_SUFFIX: ''
?                                     ^^
+   CI_IMAGE_SYSTEM_PROBE_X64_SUFFIX: _test_only
?                                     ^^^^^^^^^^
-   CI_IMAGE_WIN_1809_X64: v55750746-d62c2509
?                               ^^^    ------
+   CI_IMAGE_WIN_1809_X64: v55781556-f181d356
?                              ++ ^  ++++ ++
-   CI_IMAGE_WIN_1809_X64_SUFFIX: ''
?                                 ^^
+   CI_IMAGE_WIN_1809_X64_SUFFIX: _test_only
?                                 ^^^^^^^^^^
-   CI_IMAGE_WIN_LTSC2022_X64: v55750746-d62c2509
?                                   ^^^    ------
+   CI_IMAGE_WIN_LTSC2022_X64: v55781556-f181d356
?                                  ++ ^  ++++ ++
-   CI_IMAGE_WIN_LTSC2022_X64_SUFFIX: ''
?                                     ^^
+   CI_IMAGE_WIN_LTSC2022_X64_SUFFIX: _test_only
?                                     ^^^^^^^^^^
    CLANG_LLVM_VER: 12.0.1
    CLUSTER_AGENT_BINARIES_DIR: bin/datadog-cluster-agent
    CLUSTER_AGENT_CLOUDFOUNDRY_BINARIES_DIR: bin/datadog-cluster-agent-cloudfoundry
    CODECOV: codecov
    CODECOV_TOKEN: ci.datadog-agent.codecov_token
    CWS_INSTRUMENTATION_BINARIES_DIR: bin/cws-instrumentation
-   DATADOG_AGENT_ARMBUILDIMAGES: v55750746-d62c2509
?                                      ^^^    ------
+   DATADOG_AGENT_ARMBUILDIMAGES: v55781556-f181d356
?                                     ++ ^  ++++ ++
-   DATADOG_AGENT_ARMBUILDIMAGES_SUFFIX: ''
?                                        ^^
+   DATADOG_AGENT_ARMBUILDIMAGES_SUFFIX: _test_only
?                                        ^^^^^^^^^^
-   DATADOG_AGENT_BTF_GEN_BUILDIMAGES: v55750746-d62c2509
?                                           ^^^    ------
+   DATADOG_AGENT_BTF_GEN_BUILDIMAGES: v55781556-f181d356
?                                          ++ ^  ++++ ++
-   DATADOG_AGENT_BTF_GEN_BUILDIMAGES_SUFFIX: ''
?                                             ^^
+   DATADOG_AGENT_BTF_GEN_BUILDIMAGES_SUFFIX: _test_only
?                                             ^^^^^^^^^^
-   DATADOG_AGENT_BUILDIMAGES: v55750746-d62c2509
?                                   ^^^    ------
+   DATADOG_AGENT_BUILDIMAGES: v55781556-f181d356
?                                  ++ ^  ++++ ++
-   DATADOG_AGENT_BUILDIMAGES_SUFFIX: ''
?                                     ^^
+   DATADOG_AGENT_BUILDIMAGES_SUFFIX: _test_only
?                                     ^^^^^^^^^^
    DATADOG_AGENT_EMBEDDED_PATH: /opt/datadog-agent/embedded
-   DATADOG_AGENT_SYSPROBE_BUILDIMAGES: v55750746-d62c2509
?                                            ^^^    ------
+   DATADOG_AGENT_SYSPROBE_BUILDIMAGES: v55781556-f181d356
?                                           ++ ^  ++++ ++
-   DATADOG_AGENT_SYSPROBE_BUILDIMAGES_SUFFIX: ''
?                                              ^^
+   DATADOG_AGENT_SYSPROBE_BUILDIMAGES_SUFFIX: _test_only
?                                              ^^^^^^^^^^
-   DATADOG_AGENT_WINBUILDIMAGES: v55750746-d62c2509
?                                      ^^^    ------
+   DATADOG_AGENT_WINBUILDIMAGES: v55781556-f181d356
?                                     ++ ^  ++++ ++
-   DATADOG_AGENT_WINBUILDIMAGES_SUFFIX: ''
?                                        ^^
+   DATADOG_AGENT_WINBUILDIMAGES_SUFFIX: _test_only
?                                        ^^^^^^^^^^
    DD_AGENT_TESTING_DIR: $CI_PROJECT_DIR/test/new-e2e/tests
    DD_PKG_VERSION: latest
    DEB_GPG_KEY: ci.datadog-agent.deb_signing_private_key_${DEB_GPG_KEY_ID}
    DEB_GPG_KEY_ID: c0962c7d
    DEB_GPG_KEY_NAME: Datadog, Inc. APT key
    DEB_RPM_TESTING_BUCKET_BRANCH: testing
    DEB_S3_BUCKET: apt.datad0g.com
    DEB_SIGNING_PASSPHRASE: ci.datadog-agent.deb_signing_key_passphrase_${DEB_GPG_KEY_ID}
    DEB_TESTING_S3_BUCKET: apttesting.datad0g.com
    DOCKER_REGISTRY_LOGIN: ci.datadog-agent.docker_hub_login
    DOCKER_REGISTRY_PWD: ci.datadog-agent.docker_hub_pwd
    DOCKER_REGISTRY_RO: dockerhub-readonly
    DOCKER_REGISTRY_URL: docker.io
    DOGSTATSD_BINARIES_DIR: bin/dogstatsd
    E2E_AZURE: e2e-azure
    E2E_GCP: e2e-gcp
    EXECUTOR_JOB_SECTION_ATTEMPTS: 2
    FF_KUBERNETES_HONOR_ENTRYPOINT: true
    FF_SCRIPT_SECTIONS: 1
    FF_TIMESTAMPS: true
    GENERAL_ARTIFACTS_CACHE_BUCKET_URL: https://dd-agent-omnibus.s3.amazonaws.com
    GET_SOURCES_ATTEMPTS: 2
    GITLAB_TOKEN: gitlab-token
    GO_TEST_SKIP_FLAKE: 'true'
    INSTALLER_TESTING_S3_BUCKET: installtesting.datad0g.com
    INSTALL_SCRIPT_API_KEY_ORG2: install-script-api-key-org-2
    INTEGRATION_WHEELS_CACHE_BUCKET: dd-agent-omnibus
    KERNEL_MATRIX_TESTING_ARM_AMI_ID: ami-0b5f838a19d37fc61
    KERNEL_MATRIX_TESTING_X86_AMI_ID: ami-05b3973acf5422348
    KITCHEN_INFRASTRUCTURE_FLAKES_RETRY: 2
    MACOS_GITHUB_APP_1: macos-github-app-one
    MACOS_GITHUB_APP_2: macos-github-app-two
    MACOS_S3_BUCKET: dd-agent-macostesting
    OMNIBUS_BASE_DIR: /omnibus
    OMNIBUS_GIT_CACHE_DIR: /tmp/omnibus-git-cache
    OMNIBUS_PACKAGE_DIR: $CI_PROJECT_DIR/omnibus/pkg/
    OMNIBUS_PACKAGE_DIR_SUSE: $CI_PROJECT_DIR/omnibus/suse/pkg
    PROCESS_S3_BUCKET: datad0g-process-agent
    RELEASE_VERSION_6: nightly
    RELEASE_VERSION_7: nightly-a7
    RESTORE_CACHE_ATTEMPTS: 2
    RPM_GPG_KEY: ci.datadog-agent.rpm_signing_private_key_${RPM_GPG_KEY_ID}
    RPM_GPG_KEY_ID: b01082d3
    RPM_GPG_KEY_NAME: Datadog, Inc. RPM key
    RPM_S3_BUCKET: yum.datad0g.com
    RPM_SIGNING_PASSPHRASE: ci.datadog-agent.rpm_signing_key_passphrase_${RPM_GPG_KEY_ID}
    RPM_TESTING_S3_BUCKET: yumtesting.datad0g.com
    RUN_E2E_TESTS: auto
    RUN_KMT_TESTS: auto
    RUN_UNIT_TESTS: auto
    S3_ARTIFACTS_URI: s3://dd-ci-artefacts-build-stable/$CI_PROJECT_NAME/$CI_PIPELINE_ID
    S3_CP_CMD: aws s3 cp $S3_CP_OPTIONS
    S3_CP_OPTIONS: --no-progress --region us-east-1 --sse AES256
    S3_DD_AGENT_OMNIBUS_BTFS_URI: s3://dd-agent-omnibus/btfs
    S3_DD_AGENT_OMNIBUS_JAVA_URI: s3://dd-agent-omnibus/openjdk
    S3_DD_AGENT_OMNIBUS_LLVM_URI: s3://dd-agent-omnibus/llvm
    S3_DSD6_URI: s3://dsd6-staging
    S3_OMNIBUS_CACHE_BUCKET: dd-ci-datadog-agent-omnibus-cache-build-stable
    S3_OMNIBUS_GIT_CACHE_BUCKET: dd-ci-datadog-agent-omnibus-git-cache-build-stable
    S3_PERMANENT_ARTIFACTS_URI: s3://dd-ci-persistent-artefacts-build-stable/$CI_PROJECT_NAME
    S3_PROJECT_ARTIFACTS_URI: s3://dd-ci-artefacts-build-stable/$CI_PROJECT_NAME
    S3_RELEASE_ARTIFACTS_URI: s3://dd-release-artifacts/$CI_PROJECT_NAME/$CI_PIPELINE_ID
    S3_RELEASE_INSTALLER_ARTIFACTS_URI: s3://dd-release-artifacts/datadog-installer/$CI_PIPELINE_ID
    S3_SBOM_STORAGE_URI: s3://sbom-root-us1-ddbuild-io/$CI_PROJECT_NAME/$CI_PIPELINE_ID
    SLACK_AGENT: slack-agent-ci
    SMP_ACCOUNT: smp
    STATIC_BINARIES_DIR: bin/static
    SYSTEM_PROBE_BINARIES_DIR: bin/system-probe
    USE_S3_CACHING: --omnibus-s3-cache
    VCPKG_BLOB_SAS_URL: ci.datadog-agent-buildimages.vcpkg_blob_sas_url
    WINDOWS_BUILDS_S3_BUCKET: $WIN_S3_BUCKET/builds
    WINDOWS_POWERSHELL_DIR: $CI_PROJECT_DIR/signed_scripts
    WINDOWS_TESTING_S3_BUCKET_A6: pipelines/A6/$CI_PIPELINE_ID
    WINDOWS_TESTING_S3_BUCKET_A7: pipelines/A7/$CI_PIPELINE_ID
    WINGET_PAT: ci.datadog-agent.winget_pat
    WIN_S3_BUCKET: dd-agent-mstesting

Changes Summary

Removed Modified Added Renamed
0 1 0 0

ℹ️ Diff available in the job log.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 13, 2025

Uncompressed package size comparison

Comparison with ancestor cd14a63fe80ff6b200374d45e2a34ffc158f2ab1

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 4.37MB 870.30MB 865.93MB 0.50MB
datadog-agent-x86_64-rpm 4.37MB 880.07MB 875.70MB 0.50MB
datadog-agent-x86_64-suse 4.37MB 880.07MB 875.70MB 0.50MB
datadog-heroku-agent-amd64-deb 2.46MB 443.49MB 441.04MB 0.50MB
datadog-iot-agent-amd64-deb 0.76MB 62.51MB 61.75MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.76MB 62.58MB 61.82MB 0.50MB
datadog-iot-agent-x86_64-suse 0.76MB 62.58MB 61.82MB 0.50MB
datadog-dogstatsd-amd64-deb 0.75MB 42.31MB 41.57MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.75MB 42.39MB 41.64MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.75MB 42.39MB 41.64MB 0.50MB
datadog-dogstatsd-arm64-deb 0.35MB ⚠️ 40.18MB 39.83MB 0.50MB
datadog-agent-aarch64-rpm 0.24MB ⚠️ 864.43MB 864.18MB 0.50MB
datadog-agent-arm64-deb 0.24MB ⚠️ 854.68MB 854.43MB 0.50MB
datadog-iot-agent-arm64-deb 0.09MB ⚠️ 59.10MB 59.00MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.09MB ⚠️ 59.17MB 59.08MB 0.50MB

Decision

❌ Failed

Currently this PR is blocked, you can reach out to #agent-delivery-help to get support/ask for an exception.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 13, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55825244 --os-family=ubuntu

Note: This applies to commit e8a1cc7

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 841.83MiB 847.49MiB 203.49MiB 212.83MiB
static_quality_gate_agent_deb_arm64 826.84MiB 858.45MiB 182.64MiB 214.3MiB
static_quality_gate_agent_rpm_amd64 841.7MiB 858.45MiB 205.93MiB 214.3MiB
static_quality_gate_agent_rpm_arm64 826.77MiB 858.45MiB 184.77MiB 214.3MiB
static_quality_gate_agent_suse_amd64 841.71MiB 858.45MiB 205.93MiB 214.3MiB
static_quality_gate_agent_suse_arm64 826.87MiB 858.45MiB 184.77MiB 214.3MiB
static_quality_gate_dogstatsd_deb_amd64 40.43MiB 858.45MiB 10.69MiB 214.3MiB
static_quality_gate_dogstatsd_deb_arm64 38.39MiB 858.45MiB 9.22MiB 214.3MiB
static_quality_gate_dogstatsd_rpm_amd64 40.43MiB 858.45MiB 10.7MiB 214.3MiB
static_quality_gate_dogstatsd_suse_amd64 40.43MiB 858.45MiB 10.7MiB 214.3MiB
static_quality_gate_iot_agent_deb_amd64 59.69MiB 858.45MiB 14.93MiB 214.3MiB
static_quality_gate_iot_agent_deb_arm64 56.44MiB 858.45MiB 12.82MiB 214.3MiB
static_quality_gate_iot_agent_rpm_amd64 59.69MiB 858.45MiB 14.95MiB 214.3MiB
static_quality_gate_iot_agent_rpm_arm64 56.44MiB 858.45MiB 12.83MiB 214.3MiB
static_quality_gate_iot_agent_suse_amd64 59.69MiB 858.45MiB 14.95MiB 214.3MiB
static_quality_gate_docker_agent_amd64 926.1MiB 931.7MiB 309.77MiB 318.67MiB
static_quality_gate_docker_agent_arm64 934.53MiB 944.08MiB 293.42MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.1GiB 1.11GiB 384.9MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.1GiB 1.11GiB 364.5MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 48.57MiB 57.88MiB 18.46MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.58MiB 56.27MiB 17.19MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 269.57MiB 277.7MiB 108.05MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 284.07MiB 293.73MiB 102.67MiB 112.12MiB

Copy link

cit-pr-commenter bot commented Feb 13, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7a1dbaf-646f-47cc-9842-430a90eb405c

Baseline: cd14a63
Comparison: e8a1cc7
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.92 [-1.14, +4.99] 1 Logs
file_tree memory utilization +0.77 [+0.72, +0.83] 1 Logs
quality_gate_idle_all_features memory utilization +0.67 [+0.61, +0.72] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http1 egress throughput +0.07 [-0.89, +1.03] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.07 [-0.86, +1.00] 1 Logs
quality_gate_idle memory utilization +0.04 [-0.02, +0.10] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api ingress throughput +0.00 [-0.30, +0.31] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.69, +0.65] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.07 [-0.95, +0.82] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.07 [-0.85, +0.72] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.51 [-0.97, -0.05] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.85 [-1.62, -0.08] 1 Logs
tcp_syslog_to_blackhole ingress throughput -2.99 [-3.06, -2.92] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -4.22 [-5.09, -3.35] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ❌

Please find below the results from static quality gates

Error

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_rpm_amd64 DataNotFound 858.45MiB DataNotFound 214.3MiB
Gate failure full details
Quality gate Error type Error message
static_quality_gate_agent_rpm_amd64 StackTrace Traceback (most recent call last):
File "/go/src/github.com/DataDog/datadog-agent/tasks/quality_gates.py", line 121, in parse_and_trigger_gates
gate_mod.entrypoint(**gate_inputs)
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/static_quality_gate_agent_rpm_amd64.py", line 5, in entrypoint
generic_package_agent_quality_gate(
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 69, in generic_package_agent_quality_gate
package_on_wire_size, package_on_disk_size = calculate_package_size(
^^^^^^^^^^^^^^^^^^^^^^^
File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 10, in calculate_package_size
extract_package(ctx=ctx, package_os=package_os, package_path=package_path, extract_dir=extract_dir)
File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 72, in extract_package
return extract_rpm_package(ctx, package_path, extract_dir)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 65, in extract_rpm_package
ctx.run(f"rpm2cpio {package_path}
Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 841.91MiB 847.49MiB 203.48MiB 212.83MiB
static_quality_gate_agent_deb_arm64 827.0MiB 858.45MiB 182.89MiB 214.3MiB
static_quality_gate_agent_rpm_arm64 826.94MiB 858.45MiB 184.79MiB 214.3MiB
static_quality_gate_agent_suse_amd64 841.88MiB 858.45MiB 205.97MiB 214.3MiB
static_quality_gate_agent_suse_arm64 827.0MiB 858.45MiB 184.79MiB 214.3MiB
static_quality_gate_dogstatsd_deb_amd64 40.43MiB 49.7MiB 10.69MiB 20.6MiB
static_quality_gate_dogstatsd_deb_arm64 38.39MiB 48.1MiB 9.22MiB 19.1MiB
static_quality_gate_dogstatsd_rpm_amd64 40.43MiB 49.7MiB 10.7MiB 20.6MiB
static_quality_gate_dogstatsd_suse_amd64 40.43MiB 49.7MiB 10.7MiB 20.6MiB
static_quality_gate_iot_agent_deb_amd64 59.69MiB 69.0MiB 14.93MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.44MiB 66.4MiB 12.81MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.69MiB 69.0MiB 14.94MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.44MiB 66.4MiB 12.83MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.69MiB 69.0MiB 14.94MiB 24.8MiB
static_quality_gate_docker_agent_amd64 926.14MiB 931.7MiB 309.78MiB 318.67MiB
static_quality_gate_docker_agent_arm64 934.57MiB 944.08MiB 293.42MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.1GiB 1.1GiB 384.89MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.1GiB 1.1GiB 364.49MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 48.57MiB 57.88MiB 18.46MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.58MiB 56.27MiB 17.19MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 269.57MiB 277.7MiB 108.05MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 284.07MiB 293.73MiB 102.67MiB 112.12MiB

@pgimalac pgimalac closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant