buffered_metrics: reduce a bit lock contention #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
062e18c introduced a performance regression by trying to fix the computation of the actual sampling rate. This commit takes some shortcuts to reduce lock contention while trying to keep the sampling rate correct.
vickenty
previously approved these changes
Nov 10, 2023
Comment on lines
+198
to
+199
| if s.specifiedRate != 1.0 { | ||
| rate = s.specifiedRate |
There was a problem hiding this comment.
This doesn't match comment on specifiedRate. Should we be checking totalSamples in the condition above?
There was a problem hiding this comment.
I'll update the comment, originally I planned to try to do something smarter, but I think it would require more thinking .. so reverting to the previous behavior is a better first step
scottopell
reviewed
Nov 10, 2023
Co-authored-by: Vickenty Fesunov <[email protected]>
Co-authored-by: Scott Opell <[email protected]>
Co-authored-by: Scott Opell <[email protected]>
vickenty
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
062e18c introduced a performance regression by trying to fix the computation of the actual sampling rate.
This commit takes some shortcuts to reduce lock contention while trying to keep the sampling rate correct.