[CONTINT-3937] Fix origin detection when the cgroup namespace is shared but is not host cgroup ns #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vboulineau
reviewed
Mar 18, 2024
AliDatadog
changed the title
carlosroman
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed e2e test failures on Amazon Linux ECS Optimized OS. It runs with cgroupv1. The
kindnodes are using docker and the pods use containerd. All the pods are running containers in the same cgroup namespace but this ns is the one allocated to the docker nodes, not the host cgroup namespace. Thus, we don't verify that the cid is found in /proc/self/cgroup whereas we should. We also don't send the cgroup inode.