Fix cgroup parsing in ECS Fargate #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayz
previously approved these changes
Mar 28, 2024
rayz
approved these changes
Mar 28, 2024
imle
added a commit
to imle/datadog-go
that referenced
this pull request
Jul 25, 2024
* origin/master: update comments fix unit tests using global state fix unit tests Send both origin the container-id and the ENTITY_ID Fix cgroup parsing in ECS Fargate (DataDog#305) added dedicated codepath + comment fix cgroupv1 origin detection add description to test make sure we retrieve the cgroup inode when the cid is not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex being used to parse ECS fargate container IDs is incorrect.
More details here: DataDog/datadog-agent#24186
It looks like this is the only other place which uses this regex
It is worth noting that this should not really be an issue here, as this regex is used to parse the
mountinfofile, and we are filtering for the existence ofsandboxeswhich is unavailable in fargate, and the entry should be a regular docker ID in non-fargate ECS. So this PR should be more of a noop, but cleaning up a known non-working regex