Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevate permissions to write packages for release-serverless-init.yml #526

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

nina9753
Copy link
Contributor

@nina9753 nina9753 commented Jan 27, 2025

Adds write permissions for packages and content for release-serverless-init.yml
Based on VULN-8322 repo update

tested here successfully

@nina9753 nina9753 requested a review from a team as a code owner January 27, 2025 15:12
@@ -35,6 +35,9 @@ env:
jobs:
release-serverless-init:
runs-on: ubuntu-22.04
permissions:
packages: write
contents: write
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the contents permission needed? Based on the GitHub docs that's for creating a release

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token

Copy link
Contributor Author

@nina9753 nina9753 Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought one of the child scripts might update some binaries (build_binary_and_layer_dockerized), but after double-checking, I don't think that is the case. I'll update the PR

Copy link
Contributor

@duncanpharvey duncanpharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nina9753 nina9753 merged commit 8ed09b2 into main Jan 27, 2025
24 of 27 checks passed
@nina9753 nina9753 deleted the nina.rei/serverless-init_release_permission_update branch January 27, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants