aj/fix fd max metric #535
Merged
aj/fix fd max metric #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bottlecap/src/tags/lambda/tags.rs
Outdated
| @@ -49,7 +49,7 @@ const FUNCTION_TAGS_KEY: &str = "_dd.tags.function"; | |||
| // TODO(astuyve) decide what to do with the version | |||
| const EXTENSION_VERSION_KEY: &str = "dd_extension_version"; | |||
| // TODO(duncanista) figure out a better way to not hardcode this | |||
| const EXTENSION_VERSION: &str = "68-next"; | |||
| const EXTENSION_VERSION: &str = "69-next"; | |||
There was a problem hiding this comment.
is it a good idea to change the version in this PR?
alexgallotta
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the early return here while mapping through the PID list means if a PID dies, we immediately stop reporting metrics from the rest.
This change just trace-level logs that and moves on.
In the future, we should rescan the pid list occasionally
before:
after:
