feat: add zstd and compress #558
Merged
+506
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanista
reviewed
Feb 18, 2025
bottlecap/src/logs/flusher.rs
Outdated
|
|
||
| if !data.is_empty() { | ||
| let resp: Result<reqwest::Response, reqwest::Error> = client | ||
| .post(&url) | ||
| .header("DD-API-KEY", api_key) | ||
| .header("DD-PROTOCOL", "agent-json") | ||
| .header("Content-Type", "application/json") | ||
| .body(data) | ||
| .header("Content-Encoding", "zstd") |
There was a problem hiding this comment.
should we add an option to enable/disable decompression?
It might be needed for audit or other user side application
duncanista
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds zstd and compresses log payloads. Improves perf for people sending large/many logs:
I did not test a representative corpus of data so my intention is to test it in self monitoring, but I assume most logs are duplicates and will compress nicely. Went from 44mb on the network to 14mb, and dropped post runtime duration substantially, so that seems worthwhile.