rename bad funcs instead of removing their samples #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the samples for functions that have known inlining issues skews the PGO profile and might cause previously cold functions to be promoted to hot functions. It's probably not a big issue, but this is an easy improvement to make, so why not. Kudos to Michael Pratt for pointing this out pointing this out in #3 (comment)
felixge
force-pushed
the
felix.geisendoerfer/PROF-9665-improve-workaround
branch
from
1830482 to
b21d138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the samples for functions that have known inlining issues skews the PGO profile and might cause previously cold functions to be promoted to hot functions.
It's probably not a big issue, but this is an easy improvement to make, so why not.
Kudos to Michael Pratt for pointing this out pointing this out in #3 (comment)