Fix flaky test in TLVBlockFileReader #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambushwork
approved these changes
Jul 24, 2024
| @@ -88,6 +89,7 @@ internal class TLVBlockFileReaderTest { | |||
| @Test | |||
| fun `M log error W read() { invalid TLV type }`() { | |||
| // Given | |||
| assumeTrue(fakeDataString.length > 2) | |||
There was a problem hiding this comment.
Minor: this assumption can fix flaky test, but it seems this case worth being covered as well. we can have a if else condition to test if the length is smaller or equal than 2, internalLogger should output error which starts with "Failed to deserialize TLV data length".
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2140 +/- ##
===========================================
- Coverage 70.00% 69.88% -0.12%
===========================================
Files 726 726
Lines 26970 26980 +10
Branches 4521 4522 +1
===========================================
- Hits 18879 18853 -26
- Misses 6817 6857 +40
+ Partials 1274 1270 -4 |
jonathanmos
approved these changes
Jul 24, 2024
xgouchet
force-pushed
the
xgouchet/flaky_tests_tlv
branch
from
f3a980e to
89d5a79
Compare
mariusc83
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We had some flakiness in the TLV tests