RUM-7332: Add instrumented test for Compose Session Replay #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambushwork
force-pushed
the
yl/compose/instrumental-test
branch
from
26c3d32 to
e07743a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2469 +/- ##
===========================================
+ Coverage 69.95% 69.97% +0.02%
===========================================
Files 786 786
Lines 29298 29298
Branches 4889 4889
===========================================
+ Hits 20493 20500 +7
+ Misses 7439 7436 -3
+ Partials 1366 1362 -4 |
jonathanmos
previously approved these changes
Dec 31, 2024
ambushwork
force-pushed
the
yl/compose/instrumental-test
branch
from
e07743a to
209c8a0
Compare
ambushwork
force-pushed
the
yl/compose/instrumental-test
branch
from
209c8a0 to
2d982f2
Compare
0xnm
approved these changes
Jan 2, 2025
| ) | ||
|
|
||
| @Test | ||
| @Ignore("To fix in RUM-7899: The test is flaky among different APIS") |
There was a problem hiding this comment.
Suggested change
| @Ignore("To fix in RUM-7899: The test is flaky among different APIS") | |
| @Ignore("To fix in RUM-7899: The test is flaky among different APIs") |
| .padding(16.dp) | ||
| .clip(RoundedCornerShape(16.dp)) | ||
| .background(Color.Black), | ||
| onClick = {} |
Comment on lines
+30
to
+37
| Checkbox(checked = true, onCheckedChange = {}) | ||
| Checkbox(checked = false, onCheckedChange = {}) | ||
|
|
||
| Switch(checked = true, onCheckedChange = {}) | ||
| Switch(checked = false, onCheckedChange = {}) | ||
|
|
||
| RadioButton(selected = true, onClick = {}) | ||
| RadioButton(selected = false, onClick = {}) |
There was a problem hiding this comment.
should all these be empty? or it is just to make them respond to click events?
xgouchet
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add instrumented test for Compose Session Replay
Motivation
RUM-7332
Review checklist (to be filled by reviewers)