Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-8141: Add OpenTracing API as exported dependency to OkHttp instrumentation #2488

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Jan 17, 2025

What does this PR do?

Fixes #2486, check for more details there.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners January 17, 2025 15:28
@0xnm 0xnm force-pushed the nogorodnikov/rum-8141/add-opentracing-api-as-api-dependency-to-okhttp-instrumentation branch from b447582 to 80099c4 Compare January 17, 2025 15:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (58f27a4) to head (80099c4).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2488      +/-   ##
===========================================
+ Coverage    69.88%   69.97%   +0.09%     
===========================================
  Files          788      788              
  Lines        29647    29647              
  Branches      4961     4961              
===========================================
+ Hits         20717    20744      +27     
+ Misses        7548     7526      -22     
+ Partials      1382     1377       -5     

see 33 files with indirect coverage changes

@0xnm 0xnm merged commit 1424c51 into develop Jan 20, 2025
24 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-8141/add-opentracing-api-as-api-dependency-to-okhttp-instrumentation branch January 20, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants