-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RUM Schema #2492
Update RUM Schema #2492
Conversation
features/dd-sdk-android-rum/src/main/json/rum/_rect-schema.json
Outdated
Show resolved
Hide resolved
features/dd-sdk-android-rum/src/main/json/rum/_view-performance-schema.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need just to update API layout files, other than that LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file needs to be regenerated, it still contains properties from old schema state, also api/dd-sdk-android-rum.api
file need to regenerated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought, I did that. Let me check again.
26ddc29
to
26706f3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2492 +/- ##
===========================================
- Coverage 70.01% 69.92% -0.09%
===========================================
Files 788 788
Lines 29646 29647 +1
Branches 4962 4962
===========================================
- Hits 20755 20730 -25
- Misses 7530 7549 +19
- Partials 1361 1368 +7
|
/merge |
Devflow running:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment is still valid #2492 (comment)
What does this PR do?
Updates RUM schema to the most recent version.
It was done by using gradle tasks in the RUM target. I also checked SR, but there were no changes.
Review checklist (to be filled by reviewers)