Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RUM Schema #2492

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Update RUM Schema #2492

merged 3 commits into from
Jan 28, 2025

Conversation

maciejburda
Copy link
Member

What does this PR do?

Updates RUM schema to the most recent version.

It was done by using gradle tasks in the RUM target. I also checked SR, but there were no changes.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@maciejburda maciejburda marked this pull request as ready for review January 24, 2025 11:54
@maciejburda maciejburda requested review from a team as code owners January 24, 2025 11:54
@maciejburda maciejburda requested a review from 0xnm January 24, 2025 14:44
Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need just to update API layout files, other than that LGTM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file needs to be regenerated, it still contains properties from old schema state, also api/dd-sdk-android-rum.api file need to regenerated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought, I did that. Let me check again.

@maciejburda maciejburda force-pushed the maciey/rum-schema-update branch from 26ddc29 to 26706f3 Compare January 24, 2025 17:32
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.92%. Comparing base (63748fd) to head (d012da2).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2492      +/-   ##
===========================================
- Coverage    70.01%   69.92%   -0.09%     
===========================================
  Files          788      788              
  Lines        29646    29647       +1     
  Branches      4962     4962              
===========================================
- Hits         20755    20730      -25     
- Misses        7530     7549      +19     
- Partials      1361     1368       +7     
Files with missing lines Coverage Δ
...g/android/rum/internal/DatadogLateCrashReporter.kt 87.08% <100.00%> (+0.64%) ⬆️

... and 29 files with indirect coverage changes

xgouchet
xgouchet previously approved these changes Jan 27, 2025
jonathanmos
jonathanmos previously approved these changes Jan 27, 2025
@maciejburda maciejburda requested a review from 0xnm January 28, 2025 08:00
@maciejburda
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 28, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-28 08:01:08 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-28 12:02:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is still valid #2492 (comment)

@0xnm 0xnm dismissed stale reviews from xgouchet and jonathanmos via d012da2 January 28, 2025 12:30
@maciejburda maciejburda merged commit 6a6d48a into develop Jan 28, 2025
24 checks passed
@maciejburda maciejburda deleted the maciey/rum-schema-update branch January 28, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants