Skip to content

Commit

Permalink
stop disabling JIT optimizations on Linux (#473)
Browse files Browse the repository at this point in the history
  • Loading branch information
lucaspimentel authored Mar 18, 2020
1 parent ad8dd02 commit 13e3a7c
Showing 1 changed file with 5 additions and 15 deletions.
20 changes: 5 additions & 15 deletions src/Datadog.Trace.ClrProfiler.Native/clr_helpers.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -379,26 +379,16 @@ mdMethodSpec DefineMethodSpec(const ComPtr<IMetaDataEmit2>& metadata_emit,
}

bool DisableOptimizations() {
const auto clr_optimizations_enabled =
const auto disable_optimizations =
GetEnvironmentValue(environment::clr_disable_optimizations);

if (clr_optimizations_enabled == "1"_W ||
clr_optimizations_enabled == "true"_W) {
if (disable_optimizations == "1"_W ||
disable_optimizations == "true"_W) {
return true;
}

if (clr_optimizations_enabled == "0"_W ||
clr_optimizations_enabled == "false"_W) {
return false;
}

#ifdef _WIN32
// default to false on Windows
// default to false: don't disable JIT optimizations
return false;
#else
// default to true on Linux
return true;
#endif
}

TypeInfo RetrieveTypeForSignature(
Expand Down Expand Up @@ -699,7 +689,7 @@ HRESULT CreateAssemblyRefToMscorlib(const ComPtr<IMetaDataAssemblyEmit>& assembl
return hr;
}

bool ReturnTypeTokenforValueTypeElementType(PCCOR_SIGNATURE p_sig,
bool ReturnTypeTokenforValueTypeElementType(PCCOR_SIGNATURE p_sig,
const ComPtr<IMetaDataEmit2>& metadata_emit,
const ComPtr<IMetaDataAssemblyEmit>& assembly_emit,
mdToken* ret_type_token) {
Expand Down

0 comments on commit 13e3a7c

Please sign in to comment.