Ignore 404 exceptions (#719)

DataDog · May 15, 2020 · 4fb4e40 · 4fb4e40
1 parent b864eec
commit 4fb4e40
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/Datadog.Trace.AspNet/TracingHttpModule.cs b/src/Datadog.Trace.AspNet/TracingHttpModule.cs
@@ -167,11 +167,15 @@ private void OnError(object sender, EventArgs eventArgs)
             try
             {
                 var httpContext = (sender as HttpApplication)?.Context;
+                var exception = httpContext?.Error;
 
-                if (httpContext?.Error != null &&
-                    httpContext.Items[_httpContextScopeKey] is Scope scope)
+                // We want to ignore 404 exceptions here, as they are not errors
+                var httpException = exception as HttpException;
+                var is404 = httpException?.GetHttpCode() == 404;
+
+                if (exception != null && !is404 && httpContext.Items[_httpContextScopeKey] is Scope scope)
                 {
-                    scope.Span.SetException(httpContext.Error);
+                    scope.Span.SetException(exception);
                 }
             }
             catch (Exception ex)