Handle Nuke .NET 9 preview issue #6130

andrewlock · 2024-10-08T17:37:15Z

Summary of changes

Adds workaround for case where .NET 9 (preview) SDK is installed
lately.

Reason for change

Fixes case where Nuke no longer works if you install the .NET 9 SDK

Implementation details

Currently we have a global.json which enforces that we use the .NET
8.0.100 SDK for building in general. However, we have to use the .NET
7 SDK for running the Nuke project specifically when we're building the
Linux x64 native components.

This is because .NET 8 doesn't support CentOS 7 and can't run there,
but we have to use CentOS 7 currently for technical reasons.

We worked around this previously by specifically opting in to
major-version rollforward in the Nuke project. Unfortunately, Nuke
doesn't work out of the box with .NET 9 because of the binary
formatter
removal. Consequently we have to make sure we don't roll forward to
.NET 9 in that case.

The solution is pretty simple:

Explicitly use .NET 8 without roll forward in general
Set an env var in the CentOS7 dockerfile USE_NATIVE_SDK_VERSION=true
which switches the Nuke project to build and run on .NET 7 explicitly

Test coverage

Tested locally that it fixes the .NET 9 issue, this is the test for CI

Other details

The side-quest here was updating Nuke as it was quiet out of date. I
thought it might be required, and it required fixing a bunch of
warnings and breaking changes, so figured it would make sense to just do
the work here at the same time This ended up being a horrible pit of
errors so I abandoned it as it seems to be unnecessary.

datadog-ddstaging · 2024-10-08T18:00:28Z

Datadog Report

Branch report: andrew/update-nuke-to-8x
Commit report: 41c4daf
Test service: dd-trace-dotnet

✅ 0 Failed, 361653 Passed, 2089 Skipped, 15h 5m 5.64s Total Time

andrewlock · 2024-10-08T18:09:44Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6130) - mean (71ms)  : 68, 74
     .   : milestone, 71,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6130) - mean (1,108ms)  : 1082, 1134
     .   : milestone, 1108,
    master - mean (1,109ms)  : 1088, 1130
     .   : milestone, 1109,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6130) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (110ms)  : 108, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6130) - mean (774ms)  : 759, 789
     .   : milestone, 774,
    master - mean (781ms)  : 765, 796
     .   : milestone, 781,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6130) - mean (93ms)  : 91, 95
     .   : milestone, 93,
    master - mean (93ms)  : 91, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6130) - mean (734ms)  : 714, 753
     .   : milestone, 734,
    master - mean (739ms)  : 718, 761
     .   : milestone, 739,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6130) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6130) - mean (1,209ms)  : 1184, 1233
     .   : milestone, 1209,
    master - mean (1,197ms)  : 1171, 1222
     .   : milestone, 1197,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6130) - mean (279ms)  : 273, 284
     .   : milestone, 279,
    master - mean (277ms)  : 271, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6130) - mean (937ms)  : 918, 957
     .   : milestone, 937,
    master - mean (942ms)  : 924, 960
     .   : milestone, 942,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6130) - mean (266ms)  : 261, 270
     .   : milestone, 266,
    master - mean (268ms)  : 262, 273
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6130) - mean (930ms)  : 908, 952
     .   : milestone, 930,
    master - mean (937ms)  : 916, 958
     .   : milestone, 937,

…lled

andrewlock · 2024-10-08T19:59:11Z

Benchmarks Report for tracer 🐌

Benchmarks for #6130 compared to master:

2 benchmarks are faster, with geometric mean 1.127
2 benchmarks are slower, with geometric mean 1.125
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.83μs	43.8ns	270ns	0.0149	0.00744	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.81μs	54.2ns	347ns	0.0189	0.00945	0	5.61 KB
master	`StartStopWithChild`	net472	16.8μs	75ns	291ns	1.02	0.311	0.0864	6.06 KB
#6130	`StartStopWithChild`	net6.0	7.91μs	43ns	247ns	0.0157	0.00785	0	5.42 KB
#6130	`StartStopWithChild`	netcoreapp3.1	9.87μs	51.7ns	327ns	0.0192	0.00958	0	5.62 KB
#6130	`StartStopWithChild`	net472	16.2μs	41.3ns	160ns	1.01	0.295	0.104	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	499μs	216ns	778ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	648μs	730ns	2.83μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	826μs	214ns	828ns	0.414	3.3 KB
#6130	`WriteAndFlushEnrichedTraces`	net6.0	485μs	550ns	2.13μs	0	2.7 KB
#6130	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	622μs	906ns	3.39μs	0	2.7 KB
#6130	`WriteAndFlushEnrichedTraces`	net472	838μs	773ns	2.89μs	0.417	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	192μs	1.07μs	6.66μs	0.147	18.45 KB
master	`SendRequest`	netcoreapp3.1	218μs	1.18μs	8.24μs	0.217	20.61 KB
master	`SendRequest`	net472	0.00176ns	0.000702ns	0.00272ns	0	0 b
#6130	`SendRequest`	net6.0	197μs	1.1μs	7.85μs	0.191	18.45 KB
#6130	`SendRequest`	netcoreapp3.1	230μs	1.22μs	6.11μs	0.227	20.61 KB
#6130	`SendRequest`	net472	0.00491ns	0.00138ns	0.00534ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6130

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.75 KB	41.51 KB	-242 B	-0.58%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	576μs	1.64μs	6.12μs	0.553	0	0	41.75 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	699μs	3.53μs	16.6μs	0.336	0	0	41.73 KB
master	`WriteAndFlushEnrichedTraces`	net472	852μs	3.34μs	12.9μs	8.45	2.53	0.422	53.28 KB
#6130	`WriteAndFlushEnrichedTraces`	net6.0	572μs	2.2μs	7.94μs	0.581	0	0	41.51 KB
#6130	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	704μs	3.71μs	19.6μs	0.345	0	0	41.73 KB
#6130	`WriteAndFlushEnrichedTraces`	net472	847μs	3.66μs	13.7μs	8.63	2.47	0.411	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6130

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0	1.131	1,361.15	1,203.69

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.36μs	1.25ns	4.84ns	0.014	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	1.7ns	6.58ns	0.0139	1.02 KB
master	`ExecuteNonQuery`	net472	2.15μs	1.75ns	6.57ns	0.157	987 B
#6130	`ExecuteNonQuery`	net6.0	1.2μs	1.68ns	6.52ns	0.0143	1.02 KB
#6130	`ExecuteNonQuery`	netcoreapp3.1	1.85μs	1.42ns	5.49ns	0.0133	1.02 KB
#6130	`ExecuteNonQuery`	net472	2.11μs	2ns	7.74ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.17μs	0.644ns	2.41ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.49μs	1.09ns	4.22ns	0.0129	976 B
master	`CallElasticsearch`	net472	2.5μs	1.29ns	5ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.28μs	0.913ns	3.42ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.6μs	0.532ns	1.99ns	0.0136	1.02 KB
master	`CallElasticsearchAsync`	net472	2.57μs	1.07ns	4.01ns	0.167	1.05 KB
#6130	`CallElasticsearch`	net6.0	1.23μs	0.773ns	2.99ns	0.0135	976 B
#6130	`CallElasticsearch`	netcoreapp3.1	1.52μs	2.86ns	10.7ns	0.0129	976 B
#6130	`CallElasticsearch`	net472	2.56μs	5.16ns	20ns	0.158	995 B
#6130	`CallElasticsearchAsync`	net6.0	1.22μs	0.741ns	2.87ns	0.0134	952 B
#6130	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.98ns	3.67ns	0.0138	1.02 KB
#6130	`CallElasticsearchAsync`	net472	2.55μs	3.86ns	15ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.25μs	2.17ns	8.41ns	0.0131	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.61μs	1.36ns	5.07ns	0.0129	952 B
master	`ExecuteAsync`	net472	1.9μs	0.723ns	2.8ns	0.144	915 B
#6130	`ExecuteAsync`	net6.0	1.16μs	1.21ns	4.7ns	0.0134	952 B
#6130	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.812ns	3.14ns	0.0122	952 B
#6130	`ExecuteAsync`	net472	1.74μs	0.504ns	1.82ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.11μs	2.8ns	10.5ns	0.0308	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.16μs	3.69ns	14.3ns	0.0361	2.76 KB
master	`SendAsync`	net472	7.75μs	5.08ns	19ns	0.498	3.15 KB
#6130	`SendAsync`	net6.0	4.2μs	1.32ns	4.95ns	0.0316	2.22 KB
#6130	`SendAsync`	netcoreapp3.1	5.06μs	2.33ns	8.71ns	0.0354	2.76 KB
#6130	`SendAsync`	net472	7.8μs	3.73ns	13.9ns	0.499	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.44μs	0.626ns	2.34ns	0.023	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.22μs	1.67ns	6.24ns	0.0223	1.64 KB
master	`EnrichedLog`	net472	2.54μs	1.09ns	4.07ns	0.249	1.57 KB
#6130	`EnrichedLog`	net6.0	1.47μs	0.982ns	3.8ns	0.0233	1.64 KB
#6130	`EnrichedLog`	netcoreapp3.1	2.19μs	0.956ns	3.7ns	0.0219	1.64 KB
#6130	`EnrichedLog`	net472	2.54μs	1.45ns	5.23ns	0.25	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	114μs	128ns	495ns	0.0567	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	166ns	644ns	0.0588	0	4.28 KB
master	`EnrichedLog`	net472	146μs	134ns	519ns	0.654	0.218	4.46 KB
#6130	`EnrichedLog`	net6.0	114μs	113ns	422ns	0.0573	0	4.28 KB
#6130	`EnrichedLog`	netcoreapp3.1	120μs	169ns	656ns	0	0	4.28 KB
#6130	`EnrichedLog`	net472	148μs	270ns	1.05μs	0.666	0.222	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.06μs	1.91ns	7.39ns	0.0305	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.3μs	1.99ns	7.69ns	0.0302	2.2 KB
master	`EnrichedLog`	net472	4.85μs	2ns	7.49ns	0.32	2.02 KB
#6130	`EnrichedLog`	net6.0	3.18μs	1ns	3.75ns	0.0302	2.2 KB
#6130	`EnrichedLog`	netcoreapp3.1	4.29μs	1.75ns	6.78ns	0.03	2.2 KB
#6130	`EnrichedLog`	net472	4.8μs	1.25ns	4.68ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.35μs	0.772ns	2.89ns	0.0161	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.83μs	0.869ns	3.37ns	0.0155	0	1.14 KB
master	`SendReceive`	net472	2.14μs	1.73ns	6.7ns	0.183	0.00108	1.16 KB
#6130	`SendReceive`	net6.0	1.37μs	0.564ns	2.11ns	0.0157	0	1.14 KB
#6130	`SendReceive`	netcoreapp3.1	1.74μs	2.27ns	8.8ns	0.0148	0	1.14 KB
#6130	`SendReceive`	net472	2.04μs	0.477ns	1.85ns	0.183	0	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.67μs	1.16ns	4.48ns	0.0214	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.81μs	1.71ns	6.61ns	0.0211	1.65 KB
master	`EnrichedLog`	net472	4.46μs	2.37ns	8.87ns	0.322	2.04 KB
#6130	`EnrichedLog`	net6.0	2.75μs	5.91ns	22.9ns	0.0217	1.6 KB
#6130	`EnrichedLog`	netcoreapp3.1	3.85μs	2.56ns	9.92ns	0.0214	1.65 KB
#6130	`EnrichedLog`	net472	4.44μs	1.27ns	4.9ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6130

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.121	485.03	543.70

Faster 🎉 in #6130

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.123	722.58	643.16

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	413ns	0.329ns	1.27ns	0.00812	576 B
master	`StartFinishSpan`	netcoreapp3.1	649ns	1.79ns	6.92ns	0.0077	576 B
master	`StartFinishSpan`	net472	722ns	0.204ns	0.764ns	0.0915	578 B
master	`StartFinishScope`	net6.0	485ns	0.356ns	1.38ns	0.00974	696 B
master	`StartFinishScope`	netcoreapp3.1	733ns	1.47ns	5.67ns	0.00939	696 B
master	`StartFinishScope`	net472	844ns	0.555ns	2ns	0.104	658 B
#6130	`StartFinishSpan`	net6.0	401ns	0.116ns	0.434ns	0.00807	576 B
#6130	`StartFinishSpan`	netcoreapp3.1	623ns	0.358ns	1.34ns	0.00777	576 B
#6130	`StartFinishSpan`	net472	643ns	0.271ns	1.05ns	0.0916	578 B
#6130	`StartFinishScope`	net6.0	544ns	0.186ns	0.695ns	0.00985	696 B
#6130	`StartFinishScope`	netcoreapp3.1	764ns	0.33ns	1.28ns	0.00961	696 B
#6130	`StartFinishScope`	net472	894ns	1ns	3.87ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6130

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.130	591.09	667.76

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	591ns	0.29ns	1.12ns	0.00966	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	903ns	0.496ns	1.92ns	0.00919	696 B
master	`RunOnMethodBegin`	net472	1.07μs	0.313ns	1.13ns	0.105	658 B
#6130	`RunOnMethodBegin`	net6.0	668ns	0.306ns	1.18ns	0.00971	696 B
#6130	`RunOnMethodBegin`	netcoreapp3.1	875ns	0.674ns	2.61ns	0.0092	696 B
#6130	`RunOnMethodBegin`	net472	1.09μs	0.319ns	1.15ns	0.104	658 B

This reverts commit ece17f1.

andrewlock · 2024-10-08T23:11:52Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6130) (10.935M)   : 0, 10934517
    master (10.947M)   : 0, 10947067
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6130) (7.311M)   : 0, 7310775
    master (7.357M)   : 0, 7357178
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.658M)   : 0, 7658023

    section Manual
    master (11.170M)   : 0, 11169713

    section Manual + Automatic
    This PR (6130) (6.716M)   : 0, 6715691
    master (6.794M)   : 0, 6793735

    section DD_TRACE_ENABLED=0
    master (10.165M)   : 0, 10164915

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6130) (9.672M)   : 0, 9672029
    master (9.407M)   : 0, 9406571
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6130) (6.478M)   : 0, 6477906
    master (6.543M)   : 0, 6542618

    section Trace stats
    master (6.888M)   : 0, 6887750

    section Manual
    master (9.380M)   : 0, 9379533

    section Manual + Automatic
    This PR (6130) (6.107M)   : 0, 6107425
    master (6.148M)   : 0, 6147954

    section DD_TRACE_ENABLED=0
    master (8.559M)   : 0, 8559117

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6130) (10.222M)   : 0, 10221652
    master (9.869M)   : 0, 9868639
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6130) (6.674M)   : 0, 6673971
    master (6.673M)   : 0, 6672534
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.379M)   : 0, 7378820

    section Manual
    master (10.188M)   : 0, 10188482

    section Manual + Automatic
    This PR (6130) (6.430M)   : 0, 6429706
    master (6.068M)   : 0, 6067649

    section DD_TRACE_ENABLED=0
    master (9.316M)   : 0, 9315564

andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Oct 8, 2024

andrewlock requested a review from a team as a code owner October 8, 2024 17:37

andrewlock force-pushed the andrew/update-nuke-to-8x branch from c5b1228 to 7142fb4 Compare October 8, 2024 18:34

andrewlock added 3 commits October 8, 2024 14:41

Update Nuke to latest version

ece17f1

Try to fix issue with Nuke not working when .NET 9 preview 1 is insta…

86513cb

…lled

Try fix universal build

58ec2b2

andrewlock force-pushed the andrew/update-nuke-to-8x branch from 7142fb4 to 58ec2b2 Compare October 8, 2024 18:41

Revert "Update Nuke to latest version"

41c4daf

This reverts commit ece17f1.

andrewlock changed the title ~~Update Nuke to latest + handle .NET 9 preview isuse~~ Handle Nuke .NET 9 preview isuse Oct 8, 2024

andrewlock changed the title ~~Handle Nuke .NET 9 preview isuse~~ Handle Nuke .NET 9 preview issue Oct 8, 2024

bouwkast approved these changes Oct 10, 2024

View reviewed changes

andrewlock merged commit cabf0fd into master Oct 14, 2024
74 checks passed

andrewlock deleted the andrew/update-nuke-to-8x branch October 14, 2024 12:00

github-actions bot added this to the vNext-v3 milestone Oct 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle Nuke .NET 9 preview issue #6130

Handle Nuke .NET 9 preview issue #6130

andrewlock commented Oct 8, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 8, 2024 •

edited

Loading

andrewlock commented Oct 8, 2024 •

edited

Loading

andrewlock commented Oct 8, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6130

Raw results

Faster 🎉 in #6130

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6130

Faster 🎉 in #6130

Raw results

Slower ⚠️ in #6130

Raw results

andrewlock commented Oct 8, 2024

Handle Nuke .NET 9 preview issue #6130

Handle Nuke .NET 9 preview issue #6130

Conversation

andrewlock commented Oct 8, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Oct 8, 2024 • edited Loading

Datadog Report

andrewlock commented Oct 8, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 8, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6130

Raw results

Faster 🎉 in #6130

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6130

Faster 🎉 in #6130

Raw results

Slower ⚠️ in #6130

Raw results

andrewlock commented Oct 8, 2024

Throughput/Crank Report ⚡

andrewlock commented Oct 8, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 8, 2024 •

edited

Loading

andrewlock commented Oct 8, 2024 •

edited

Loading

andrewlock commented Oct 8, 2024 •

edited

Loading