Downgrade two common errors to warnings #6584

bouwkast · 2025-01-22T16:10:39Z

Summary of changes

Downgrades two common error logs to warnings.

Reason for change

There are a lot of them and they don't seem to be very actionable.

Implementation details

Error -> Warning

Test coverage

🙈

Other details

andrewlock · 2025-01-22T16:45:14Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6584) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6584) - mean (982ms)  : 959, 1004
     .   : milestone, 982,
    master - mean (985ms)  : 961, 1010
     .   : milestone, 985,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6584) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (109ms)  : 106, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6584) - mean (679ms)  : 664, 694
     .   : milestone, 679,
    master - mean (684ms)  : 667, 701
     .   : milestone, 684,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6584) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (92ms)  : 90, 93
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6584) - mean (635ms)  : 620, 650
     .   : milestone, 635,
    master - mean (635ms)  : 619, 650
     .   : milestone, 635,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6584) - mean (190ms)  : 186, 193
     .   : milestone, 190,
    master - mean (189ms)  : 186, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6584) - mean (1,087ms)  : 1063, 1112
     .   : milestone, 1087,
    master - mean (1,087ms)  : 1062, 1113
     .   : milestone, 1087,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6584) - mean (275ms)  : 270, 281
     .   : milestone, 275,
    master - mean (275ms)  : 271, 280
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6584) - mean (872ms)  : 845, 899
     .   : milestone, 872,
    master - mean (874ms)  : 845, 903
     .   : milestone, 874,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6584) - mean (264ms)  : 261, 267
     .   : milestone, 264,
    master - mean (265ms)  : 262, 268
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6584) - mean (850ms)  : 814, 886
     .   : milestone, 850,
    master - mean (854ms)  : 823, 884
     .   : milestone, 854,

datadog-ddstaging · 2025-01-22T16:50:49Z

Datadog Report

Branch report: steven/downgrade-git-error
Commit report: 40e9144
Test service: dd-trace-dotnet

✅ 0 Failed, 245608 Passed, 1992 Skipped, 18h 57m 34.97s Total Time

andrewlock · 2025-01-22T17:12:33Z

Benchmarks Report for tracer 🐌

Benchmarks for #6584 compared to master:

1 benchmarks are faster, with geometric mean 1.138
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.93μs	34.4ns	150ns	0.0159	0.00396	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	46.5ns	180ns	0.0147	0.00491	0	5.81 KB
master	`StartStopWithChild`	net472	16.4μs	47.6ns	184ns	1.04	0.296	0.0986	6.21 KB
#6584	`StartStopWithChild`	net6.0	7.93μs	43.8ns	287ns	0.0148	0.00371	0	5.62 KB
#6584	`StartStopWithChild`	netcoreapp3.1	10.1μs	53.2ns	286ns	0.0198	0.00991	0	5.8 KB
#6584	`StartStopWithChild`	net472	16μs	65.2ns	253ns	1.03	0.29	0.0967	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	465μs	317ns	1.23μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	670μs	293ns	1.13μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	861μs	342ns	1.28μs	0.428	3.3 KB
#6584	`WriteAndFlushEnrichedTraces`	net6.0	476μs	254ns	951ns	0	2.7 KB
#6584	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	680μs	280ns	1.09μs	0	2.7 KB
#6584	`WriteAndFlushEnrichedTraces`	net472	850μs	566ns	2.19μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	130μs	446ns	1.73μs	0.132	14.47 KB
master	`SendRequest`	netcoreapp3.1	146μs	453ns	1.75μs	0.219	17.27 KB
master	`SendRequest`	net472	0.0127ns	0.00368ns	0.0143ns	0	0 b
#6584	`SendRequest`	net6.0	125μs	568ns	2.41μs	0.189	14.47 KB
#6584	`SendRequest`	netcoreapp3.1	144μs	220ns	824ns	0.215	17.27 KB
#6584	`SendRequest`	net472	0.000359ns	0.000359ns	0.00139ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6584

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.49 KB	41.84 KB	349 B	0.84%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	586μs	3.04μs	14.6μs	0.573	0	0	41.69 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	711μs	3.94μs	24μs	0.351	0	0	41.49 KB
master	`WriteAndFlushEnrichedTraces`	net472	869μs	4.42μs	19.3μs	8.19	2.59	0.431	53.31 KB
#6584	`WriteAndFlushEnrichedTraces`	net6.0	567μs	2.27μs	8.19μs	0.553	0	0	41.65 KB
#6584	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	657μs	3.57μs	19.6μs	0.324	0	0	41.84 KB
#6584	`WriteAndFlushEnrichedTraces`	net472	844μs	2.24μs	8.67μs	8.45	2.53	0.422	53.27 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.26μs	1.17ns	4.51ns	0.0145	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	2.25ns	8.73ns	0.0134	0	1.02 KB
master	`ExecuteNonQuery`	net472	1.95μs	2.3ns	8.9ns	0.156	0.000976	987 B
#6584	`ExecuteNonQuery`	net6.0	1.33μs	1.11ns	4.29ns	0.0139	0	1.02 KB
#6584	`ExecuteNonQuery`	netcoreapp3.1	1.71μs	1.31ns	5.06ns	0.0137	0	1.02 KB
#6584	`ExecuteNonQuery`	net472	2.08μs	2.3ns	8.59ns	0.157	0.00103	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.3μs	0.645ns	2.41ns	0.0138	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.55μs	1.2ns	4.63ns	0.0132	976 B
master	`CallElasticsearch`	net472	2.53μs	1.93ns	7.46ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.33μs	0.594ns	2.22ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.6μs	0.998ns	3.73ns	0.0135	1.02 KB
master	`CallElasticsearchAsync`	net472	2.69μs	1.18ns	4.27ns	0.166	1.05 KB
#6584	`CallElasticsearch`	net6.0	1.19μs	0.657ns	2.46ns	0.0138	976 B
#6584	`CallElasticsearch`	netcoreapp3.1	1.65μs	1.2ns	4.66ns	0.0131	976 B
#6584	`CallElasticsearch`	net472	2.66μs	4.19ns	16.2ns	0.157	995 B
#6584	`CallElasticsearchAsync`	net6.0	1.36μs	1.44ns	5.58ns	0.0135	952 B
#6584	`CallElasticsearchAsync`	netcoreapp3.1	1.69μs	0.542ns	2.1ns	0.0141	1.02 KB
#6584	`CallElasticsearchAsync`	net472	2.69μs	3ns	11.6ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.34μs	0.474ns	1.77ns	0.0135	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.58μs	1.62ns	6.07ns	0.0126	952 B
master	`ExecuteAsync`	net472	1.86μs	0.532ns	2.06ns	0.145	915 B
#6584	`ExecuteAsync`	net6.0	1.35μs	0.792ns	2.96ns	0.0135	952 B
#6584	`ExecuteAsync`	netcoreapp3.1	1.66μs	0.921ns	3.45ns	0.0123	952 B
#6584	`ExecuteAsync`	net472	1.84μs	0.608ns	2.35ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.35μs	2.24ns	8.39ns	0.0329	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.33μs	2.03ns	7.85ns	0.0373	2.85 KB
master	`SendAsync`	net472	7.34μs	1.84ns	7.11ns	0.495	3.12 KB
#6584	`SendAsync`	net6.0	4.48μs	1.01ns	3.77ns	0.0314	2.31 KB
#6584	`SendAsync`	netcoreapp3.1	5.25μs	3.27ns	12.7ns	0.0396	2.85 KB
#6584	`SendAsync`	net472	7.36μs	1.6ns	6.21ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.43μs	1.14ns	4.25ns	0.0229	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.23μs	0.685ns	2.47ns	0.0222	1.64 KB
master	`EnrichedLog`	net472	2.54μs	1.49ns	5.77ns	0.25	1.57 KB
#6584	`EnrichedLog`	net6.0	1.51μs	1.22ns	4.4ns	0.0235	1.64 KB
#6584	`EnrichedLog`	netcoreapp3.1	2.2μs	0.567ns	2.2ns	0.0221	1.64 KB
#6584	`EnrichedLog`	net472	2.53μs	6.94ns	24ns	0.25	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	116μs	112ns	433ns	0.0579	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	120μs	254ns	951ns	0	0	4.28 KB
master	`EnrichedLog`	net472	151μs	142ns	549ns	0.684	0.228	4.46 KB
#6584	`EnrichedLog`	net6.0	117μs	134ns	519ns	0	0	4.28 KB
#6584	`EnrichedLog`	netcoreapp3.1	120μs	155ns	600ns	0.0596	0	4.28 KB
#6584	`EnrichedLog`	net472	150μs	123ns	477ns	0.673	0.224	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.98μs	1.02ns	3.94ns	0.0309	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.13μs	2.63ns	10.2ns	0.0289	2.2 KB
master	`EnrichedLog`	net472	4.98μs	1.33ns	5.13ns	0.32	2.02 KB
#6584	`EnrichedLog`	net6.0	2.98μs	1.26ns	4.86ns	0.0312	2.2 KB
#6584	`EnrichedLog`	netcoreapp3.1	4.27μs	1.5ns	5.81ns	0.0299	2.2 KB
#6584	`EnrichedLog`	net472	4.91μs	1.89ns	7.31ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.32μs	0.755ns	2.92ns	0.0158	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.81μs	0.395ns	1.42ns	0.0153	1.14 KB
master	`SendReceive`	net472	2.22μs	1.12ns	4.33ns	0.183	1.16 KB
#6584	`SendReceive`	net6.0	1.32μs	0.516ns	2ns	0.0158	1.14 KB
#6584	`SendReceive`	netcoreapp3.1	1.78μs	0.823ns	3.19ns	0.0151	1.14 KB
#6584	`SendReceive`	net472	2.09μs	1.11ns	4.29ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.82μs	1.18ns	4.57ns	0.0226	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.81μs	1.45ns	5.63ns	0.021	1.65 KB
master	`EnrichedLog`	net472	4.31μs	6.23ns	24.1ns	0.322	2.04 KB
#6584	`EnrichedLog`	net6.0	2.78μs	1.5ns	5.6ns	0.0221	1.6 KB
#6584	`EnrichedLog`	netcoreapp3.1	3.84μs	1.57ns	5.89ns	0.0211	1.65 KB
#6584	`EnrichedLog`	net472	4.47μs	8.92ns	34.5ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6584

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.138	452.77	397.88

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	452ns	0.614ns	2.38ns	0.00813	576 B
master	`StartFinishSpan`	netcoreapp3.1	564ns	0.835ns	3.01ns	0.00773	576 B
master	`StartFinishSpan`	net472	600ns	1.25ns	4.84ns	0.0918	578 B
master	`StartFinishScope`	net6.0	536ns	0.73ns	2.83ns	0.00984	696 B
master	`StartFinishScope`	netcoreapp3.1	687ns	1.67ns	6.48ns	0.00963	696 B
master	`StartFinishScope`	net472	868ns	1.77ns	6.84ns	0.104	658 B
#6584	`StartFinishSpan`	net6.0	398ns	0.616ns	2.39ns	0.00805	576 B
#6584	`StartFinishSpan`	netcoreapp3.1	551ns	1.19ns	4.62ns	0.00775	576 B
#6584	`StartFinishSpan`	net472	636ns	0.989ns	3.83ns	0.0918	578 B
#6584	`StartFinishScope`	net6.0	552ns	1.33ns	5.16ns	0.00968	696 B
#6584	`StartFinishScope`	netcoreapp3.1	659ns	2.91ns	15.4ns	0.00924	696 B
#6584	`StartFinishScope`	net472	818ns	1.18ns	4.57ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	626ns	0.918ns	3.56ns	0.00978	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	853ns	1.3ns	5.02ns	0.00942	696 B
master	`RunOnMethodBegin`	net472	1.02μs	2ns	7.73ns	0.104	658 B
#6584	`RunOnMethodBegin`	net6.0	594ns	1.37ns	5.29ns	0.00993	696 B
#6584	`RunOnMethodBegin`	netcoreapp3.1	935ns	0.484ns	1.81ns	0.00945	696 B
#6584	`RunOnMethodBegin`	net472	1.1μs	1.09ns	4.24ns	0.104	658 B

datadog-ddstaging · 2025-01-24T15:33:26Z

Datadog Report

Branch report: steven/downgrade-git-error
Commit report: 40e9144
Test service: dd-trace-dotnet

✅ 0 Failed, 245610 Passed, 1992 Skipped, 18h 58m 5.75s Total Time

Downgrade two common errors to warnings

40e9144

bouwkast requested review from a team as code owners January 22, 2025 16:10

tonyredondo approved these changes Jan 22, 2025

View reviewed changes

andrewlock approved these changes Jan 22, 2025

View reviewed changes

bouwkast merged commit 592660c into master Jan 27, 2025
124 of 127 checks passed

bouwkast deleted the steven/downgrade-git-error branch January 27, 2025 14:30

github-actions bot added this to the vNext-v3 milestone Jan 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Downgrade two common errors to warnings #6584

Downgrade two common errors to warnings #6584

bouwkast commented Jan 22, 2025

andrewlock commented Jan 22, 2025

datadog-ddstaging bot commented Jan 22, 2025 •

edited

Loading

andrewlock commented Jan 22, 2025

Raw results

Raw results

Raw results

More allocations ⚠️ in #6584

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6584

Raw results

Raw results

datadog-ddstaging bot commented Jan 24, 2025

Downgrade two common errors to warnings #6584

Downgrade two common errors to warnings #6584

Conversation

bouwkast commented Jan 22, 2025

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

andrewlock commented Jan 22, 2025

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Jan 22, 2025 • edited Loading

Datadog Report

andrewlock commented Jan 22, 2025

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6584

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6584

Raw results

Raw results

datadog-ddstaging bot commented Jan 24, 2025

Datadog Report

datadog-ddstaging bot commented Jan 22, 2025 •

edited

Loading