[tracer] Add s3 instrumentation #6590

nhulston · 2025-01-23T20:45:09Z

Summary of changes

Creates an automatic instrumentation for S3's common & important operations (and their async equivalents):

Object management:

GetObject
PutObject
DeleteObject
CopyObject
ListObjectsV2

Bucket management:

PutBucket
DeleteBucket
ListBuckets

Multipart uploads:

InitiateMultipartUpload
UploadPart
CompleteMultipartUpload

Reason for change

More enriched spans for AWS SDK in S3
S3 is instrumented in other tracers
This is a prerequisite for a new feature I'm working on called 'span pointers'. See my PR in the Java tracer for more context.

Implementation details

Instrumented AmazonS3Client and the specified methods
Set bucket and object key tags (in alignment with other tracers) for operations where these fields exist

Test coverage

Unit tests:

cd tracer
dotnet test ./test/Datadog.Trace.ClrProfiler.Managed.Tests

Integration tests:

cd tracer

# Start docker localstock
docker run --rm -it -p 4566:4566 -p 4571:4571 -e SERVICES=s3 localstack/localstack

# Build tracer
./build.sh BuildTracerHome -buildConfiguration Debug -framework net6.0

# Run integation tests
./build.sh BuildAndRunOSxIntegrationTests -buildConfiguration Debug -framework net6.0 -Filter "Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsS3Tests" -SampleName Samples.AWS.S3

Manually tested every operation (see above for images). All instrumentations work since each operation's span does have a custom resource name.

Other details

For AWS S3 v3.3 and v3.5, the bucket path is given as bucket-name/. For v3.7+, the bucket path is given as bucket-name. I had to manually handle this case in RuntimePipelineInvokeIntegration to get integration tests to pass and for the http.url tags to be consistent across versions. Let me know if there's a better way to handle this.

datadog-ddstaging · 2025-01-23T21:43:30Z

Datadog Report

Branch report: nicholas.hulston/add-s3-instrumentation
Commit report: 340942b
Test service: dd-trace-dotnet

✅ 0 Failed, 574507 Passed, 5445 Skipped, 46h 28m 9.9s Total Time

andrewlock · 2025-01-23T22:17:10Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6590) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 67, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6590) - mean (993ms)  : 968, 1018
     .   : milestone, 993,
    master - mean (994ms)  : 975, 1013
     .   : milestone, 994,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6590) - mean (103ms)  : 101, 104
     .   : milestone, 103,
    master - mean (103ms)  : 100, 105
     .   : milestone, 103,

    section CallTarget+Inlining+NGEN
    This PR (6590) - mean (676ms)  : 660, 692
     .   : milestone, 676,
    master - mean (677ms)  : 662, 692
     .   : milestone, 677,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6590) - mean (90ms)  : 88, 91
     .   : milestone, 90,
    master - mean (90ms)  : 88, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (6590) - mean (633ms)  : 617, 649
     .   : milestone, 633,
    master - mean (635ms)  : 618, 651
     .   : milestone, 635,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6590) - mean (191ms)  : 187, 196
     .   : milestone, 191,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6590) - mean (1,110ms)  : 1078, 1143
     .   : milestone, 1110,
    master - mean (1,110ms)  : 1062, 1158
     .   : milestone, 1110,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6590) - mean (271ms)  : 266, 276
     .   : milestone, 271,
    master - mean (271ms)  : 266, 276
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (6590) - mean (864ms)  : 834, 895
     .   : milestone, 864,
    master - mean (875ms)  : 806, 944
     .   : milestone, 875,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6590) - mean (262ms)  : 258, 266
     .   : milestone, 262,
    master - mean (262ms)  : 258, 265
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6590) - mean (851ms)  : 818, 885
     .   : milestone, 851,
    master - mean (846ms)  : 808, 884
     .   : milestone, 846,

andrewlock · 2025-01-23T22:36:04Z

Benchmarks Report for tracer 🐌

Benchmarks for #6590 compared to master:

2 benchmarks are slower, with geometric mean 1.143
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.29μs	61.3ns	584ns	0.0163	0.00816	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	9.91μs	55.4ns	342ns	0.0149	0.00498	0	5.8 KB
master	`StartStopWithChild`	net472	16.2μs	41.6ns	161ns	1.03	0.287	0.0877	6.21 KB
#6590	`StartStopWithChild`	net6.0	7.6μs	40.6ns	295ns	0.0302	0.0151	0	5.61 KB
#6590	`StartStopWithChild`	netcoreapp3.1	9.77μs	54.1ns	338ns	0.019	0.00951	0	5.8 KB
#6590	`StartStopWithChild`	net472	16μs	32.2ns	125ns	1.04	0.306	0.0887	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	484μs	157ns	587ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	672μs	333ns	1.29μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	859μs	629ns	2.27μs	0.425	3.3 KB
#6590	`WriteAndFlushEnrichedTraces`	net6.0	498μs	290ns	1.12μs	0	2.7 KB
#6590	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	403ns	1.56μs	0	2.7 KB
#6590	`WriteAndFlushEnrichedTraces`	net472	860μs	565ns	2.19μs	0.425	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	127μs	551ns	2.14μs	0.193	14.47 KB
master	`SendRequest`	netcoreapp3.1	145μs	308ns	1.19μs	0.147	17.27 KB
master	`SendRequest`	net472	0.0107ns	0.0026ns	0.0101ns	0	0 b
#6590	`SendRequest`	net6.0	126μs	460ns	1.78μs	0.19	14.47 KB
#6590	`SendRequest`	netcoreapp3.1	141μs	583ns	2.26μs	0.21	17.27 KB
#6590	`SendRequest`	net472	0.00147ns	0.000725ns	0.00281ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	554μs	1.99μs	7.72μs	0.548	0	0	41.48 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	652μs	2.77μs	10.4μs	0.319	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	net472	873μs	2.61μs	9.78μs	8.13	2.57	0.428	53.31 KB
#6590	`WriteAndFlushEnrichedTraces`	net6.0	549μs	2.92μs	15.5μs	0.558	0	0	41.48 KB
#6590	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	657μs	3.09μs	12.3μs	0.332	0	0	41.76 KB
#6590	`WriteAndFlushEnrichedTraces`	net472	834μs	3.91μs	15.6μs	8.36	2.39	0.398	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.26μs	1.16ns	4.51ns	0.0144	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.73μs	1.02ns	3.82ns	0.013	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.14μs	1.62ns	6.06ns	0.156	0.00106	987 B
#6590	`ExecuteNonQuery`	net6.0	1.3μs	1.18ns	4.4ns	0.0142	0	1.02 KB
#6590	`ExecuteNonQuery`	netcoreapp3.1	1.73μs	2.06ns	7.99ns	0.0138	0	1.02 KB
#6590	`ExecuteNonQuery`	net472	2μs	2.1ns	7.86ns	0.157	0.001	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.2μs	0.506ns	1.83ns	0.0139	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.49μs	1.32ns	5.12ns	0.0133	976 B
master	`CallElasticsearch`	net472	2.57μs	2.55ns	9.87ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.31μs	0.731ns	2.83ns	0.0131	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	0.653ns	2.44ns	0.0139	1.02 KB
master	`CallElasticsearchAsync`	net472	2.7μs	1.36ns	5.26ns	0.167	1.05 KB
#6590	`CallElasticsearch`	net6.0	1.27μs	1.08ns	4.17ns	0.0133	976 B
#6590	`CallElasticsearch`	netcoreapp3.1	1.57μs	1.06ns	3.97ns	0.0132	976 B
#6590	`CallElasticsearch`	net472	2.44μs	4.81ns	18.6ns	0.157	995 B
#6590	`CallElasticsearchAsync`	net6.0	1.33μs	1.15ns	3.99ns	0.0128	952 B
#6590	`CallElasticsearchAsync`	netcoreapp3.1	1.68μs	0.645ns	2.41ns	0.0141	1.02 KB
#6590	`CallElasticsearchAsync`	net472	2.64μs	1.67ns	6.48ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6590

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.130	1,190.80	1,345.37

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.19μs	0.34ns	1.27ns	0.013	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.58μs	0.64ns	2.48ns	0.0125	952 B
master	`ExecuteAsync`	net472	1.85μs	0.43ns	1.61ns	0.145	915 B
#6590	`ExecuteAsync`	net6.0	1.35μs	0.648ns	2.34ns	0.0132	952 B
#6590	`ExecuteAsync`	netcoreapp3.1	1.59μs	0.633ns	2.37ns	0.0128	952 B
#6590	`ExecuteAsync`	net472	1.82μs	0.673ns	2.61ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.26μs	0.821ns	2.84ns	0.032	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.32μs	5.84ns	22.6ns	0.0373	2.85 KB
master	`SendAsync`	net472	7.46μs	1.53ns	5.94ns	0.496	3.12 KB
#6590	`SendAsync`	net6.0	4.47μs	3.71ns	13.9ns	0.0313	2.31 KB
#6590	`SendAsync`	netcoreapp3.1	5.28μs	1.38ns	4.99ns	0.0372	2.85 KB
#6590	`SendAsync`	net472	7.41μs	1.83ns	7.07ns	0.496	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.54μs	0.769ns	2.98ns	0.0232	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.07μs	1.52ns	5.89ns	0.0218	1.64 KB
master	`EnrichedLog`	net472	2.42μs	0.75ns	2.81ns	0.249	1.57 KB
#6590	`EnrichedLog`	net6.0	1.56μs	0.572ns	2.14ns	0.0226	1.64 KB
#6590	`EnrichedLog`	netcoreapp3.1	2.26μs	2.76ns	10.7ns	0.0214	1.64 KB
#6590	`EnrichedLog`	net472	2.54μs	0.761ns	2.74ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	49.4ns	178ns	0.0566	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	116μs	143ns	553ns	0	0	4.28 KB
master	`EnrichedLog`	net472	150μs	159ns	616ns	0.672	0.224	4.46 KB
#6590	`EnrichedLog`	net6.0	113μs	122ns	474ns	0.0565	0	4.28 KB
#6590	`EnrichedLog`	netcoreapp3.1	117μs	245ns	950ns	0	0	4.28 KB
#6590	`EnrichedLog`	net472	151μs	96.3ns	360ns	0.677	0.226	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.05μs	1.02ns	3.93ns	0.0304	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.23μs	1.11ns	4.29ns	0.0296	2.2 KB
master	`EnrichedLog`	net472	5.04μs	2.04ns	7.9ns	0.32	2.02 KB
#6590	`EnrichedLog`	net6.0	2.94μs	1.89ns	7.34ns	0.0309	2.2 KB
#6590	`EnrichedLog`	netcoreapp3.1	4.02μs	3.81ns	14.8ns	0.0302	2.2 KB
#6590	`EnrichedLog`	net472	4.95μs	3.72ns	14.4ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6590

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0	1.157	1,313.11	1,518.87

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.31μs	0.493ns	1.91ns	0.0157	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.76μs	0.966ns	3.74ns	0.015	1.14 KB
master	`SendReceive`	net472	2.13μs	2.1ns	7.88ns	0.183	1.16 KB
#6590	`SendReceive`	net6.0	1.52μs	1.04ns	4.03ns	0.0159	1.14 KB
#6590	`SendReceive`	netcoreapp3.1	1.69μs	1.21ns	4.54ns	0.0152	1.14 KB
#6590	`SendReceive`	net472	2.06μs	0.807ns	3.13ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.86μs	0.867ns	3.36ns	0.0228	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.93μs	2.27ns	8.81ns	0.0215	1.65 KB
master	`EnrichedLog`	net472	4.35μs	3.72ns	14.4ns	0.322	2.04 KB
#6590	`EnrichedLog`	net6.0	2.72μs	0.917ns	3.55ns	0.0231	1.6 KB
#6590	`EnrichedLog`	netcoreapp3.1	3.86μs	1.33ns	5.16ns	0.0212	1.65 KB
#6590	`EnrichedLog`	net472	4.42μs	2.35ns	8.79ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	393ns	0.822ns	3.18ns	0.00811	576 B
master	`StartFinishSpan`	netcoreapp3.1	557ns	0.987ns	3.82ns	0.00778	576 B
master	`StartFinishSpan`	net472	596ns	1.03ns	3.99ns	0.0916	578 B
master	`StartFinishScope`	net6.0	488ns	0.575ns	2.23ns	0.00984	696 B
master	`StartFinishScope`	netcoreapp3.1	712ns	1.03ns	4ns	0.00958	696 B
master	`StartFinishScope`	net472	864ns	2.22ns	8.59ns	0.104	658 B
#6590	`StartFinishSpan`	net6.0	398ns	0.637ns	2.47ns	0.00815	576 B
#6590	`StartFinishSpan`	netcoreapp3.1	594ns	2.02ns	7.81ns	0.00769	576 B
#6590	`StartFinishSpan`	net472	618ns	1.23ns	4.77ns	0.0916	578 B
#6590	`StartFinishScope`	net6.0	490ns	0.699ns	2.71ns	0.0098	696 B
#6590	`StartFinishScope`	netcoreapp3.1	717ns	0.955ns	3.7ns	0.00925	696 B
#6590	`StartFinishScope`	net472	833ns	1.35ns	5.23ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	649ns	0.948ns	3.67ns	0.00979	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	926ns	1.74ns	6.76ns	0.00968	696 B
master	`RunOnMethodBegin`	net472	1.06μs	2.02ns	7.83ns	0.104	658 B
#6590	`RunOnMethodBegin`	net6.0	636ns	0.478ns	1.85ns	0.0099	696 B
#6590	`RunOnMethodBegin`	netcoreapp3.1	902ns	1.73ns	6.7ns	0.00943	696 B
#6590	`RunOnMethodBegin`	net472	1.13μs	3.34ns	12.9ns	0.105	658 B

… and object key

…eMultipartUpload, and CompleteMultipartUploadAsync

# Conflicts: # tracer/src/Datadog.Trace/Generated/net461/Datadog.Trace.SourceGenerators/TelemetryMetricGenerator/CiVisibilityMetricsTelemetryCollector_CountCIVisibility.g.cs # tracer/src/Datadog.Trace/Generated/net461/Datadog.Trace.SourceGenerators/TelemetryMetricGenerator/CiVisibilityMetricsTelemetryCollector_DistributionCIVisibility.g.cs # tracer/src/Datadog.Trace/Generated/net6.0/Datadog.Trace.SourceGenerators/TelemetryMetricGenerator/CiVisibilityMetricsTelemetryCollector_CountCIVisibility.g.cs # tracer/src/Datadog.Trace/Generated/net6.0/Datadog.Trace.SourceGenerators/TelemetryMetricGenerator/CiVisibilityMetricsTelemetryCollector_DistributionCIVisibility.g.cs # tracer/src/Datadog.Trace/Generated/netcoreapp3.1/Datadog.Trace.SourceGenerators/TelemetryMetricGenerator/CiVisibilityMetricsTelemetryCollector_CountCIVisibility.g.cs # tracer/src/Datadog.Trace/Generated/netcoreapp3.1/Datadog.Trace.SourceGenerators/TelemetryMetricGenerator/CiVisibilityMetricsTelemetryCollector_DistributionCIVisibility.g.cs # tracer/src/Datadog.Trace/Generated/netstandard2.0/Datadog.Trace.SourceGenerators/TelemetryMetricGenerator/CiVisibilityMetricsTelemetryCollector_CountCIVisibility.g.cs # tracer/src/Datadog.Trace/Generated/netstandard2.0/Datadog.Trace.SourceGenerators/TelemetryMetricGenerator/CiVisibilityMetricsTelemetryCollector_DistributionCIVisibility.g.cs # tracer/src/Datadog.Tracer.Native/Generated/generated_calltargets.g.cpp

tracer/test/test-applications/integrations/Samples.AWS.S3/SyncHelpers.cs

…on't have tags for bucket or object key

nhulston · 2025-02-04T14:18:32Z

tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/S3/AwsS3Common.cs

+        ///   /my-bucket/           (for bucket-level calls)
+        ///   /my-bucket/key.txt    (for object calls)
+        /// </summary>
+        public static string BuildS3Path(AwsS3Tags? tags)


Had to do this to get integration tests to pass across AWSSDK.S3 versions. Would be nice if there was just a way to allow the snapshot to accept either localhost:00000/bucket/ OR localhost:00000/bucket

nhulston added 5 commits January 27, 2025 17:03

add basic S3 instrumentation for PutObject and PutObjectAsync

abb2bae

implement tags

99d4528

create basic s3 sample app

1c6707a

implement basic s3 integration tests

01734d3

run GeneratePackageVersions

8e22164

nhulston force-pushed the nicholas.hulston/add-s3-instrumentation branch from baa2cad to 8e22164 Compare January 27, 2025 22:24

nhulston added 4 commits January 28, 2025 11:30

Add aws.bucket.name and aws.object.key tags

1e3ee72

Instrument PutObject and PutObjectAsync; set tags for bucket name…

96dde22

… and object key

create basic instrumentation for CopyObject, CopyObjectAsync, Complet…

f1cde9c

…eMultipartUpload, and CompleteMultipartUploadAsync

Run GeneratePackageVersions to update call targets

2085dfb

nhulston force-pushed the nicholas.hulston/add-s3-instrumentation branch from cdea333 to 2085dfb Compare January 28, 2025 17:32

nhulston added 16 commits January 28, 2025 13:36

update calltargets

205388b

Instrument CopyObject and CompleteMultipartUpload

308d567

create GetObject integration

387122d

create DeleteObject integration

4bffcbc

create ListObjects integration

c9eb8e2

create PutBucket integration

0e4c0f0

create DeleteBucket integration

a6d606f

refactor async integrations

239409f

create ListObjectsV2 integration

9273310

refactor integrations; remove ListObjectsV1 integration in favor of v2

5e415a7

run GeneratePackageVersions

675d9e9

create ListBuckets integration

57d7e35

simplify comments

dca6ed4

create DeleteObjects integration

ed525ff

create InitiateMultipartUpload integration

6493d30

nhulston added 5 commits January 30, 2025 10:09

update tags

21d730f

fix integration tests (no uppercase bucket names)

1d8957d

fix unit tests

33135ba

update v0 operation name

fcda3fa

add NetCore snapshots

32b8589

nhulston changed the title ~~[wip] Add s3 instrumentation~~ [tracer] Add s3 instrumentation Jan 30, 2025

nhulston marked this pull request as ready for review January 30, 2025 17:24

nhulston requested review from a team as code owners January 30, 2025 17:24

DylanLovesCoffee reviewed Jan 30, 2025

View reviewed changes

tracer/test/test-applications/integrations/Samples.AWS.S3/SyncHelpers.cs Show resolved Hide resolved

nhulston force-pushed the nicholas.hulston/add-s3-instrumentation branch from 388cb26 to a5d213e Compare January 30, 2025 20:25

nhulston requested review from a team as code owners January 30, 2025 20:25

nhulston force-pushed the nicholas.hulston/add-s3-instrumentation branch from a5d213e to 32b8589 Compare January 30, 2025 20:26

Merge branch 'master' into nicholas.hulston/add-s3-instrumentation

4163a58

nhulston force-pushed the nicholas.hulston/add-s3-instrumentation branch from d603384 to 4163a58 Compare January 31, 2025 14:40

DataDog deleted a comment from github-actions bot Jan 31, 2025

nhulston and others added 5 commits January 31, 2025 09:41

Merge branch 'master' into nicholas.hulston/add-s3-instrumentation

65c52bd

update snapshots

7d631d0

manually construct s3 request paths

f3cb287

add test coverage for every instrumented operation

b2b2f2d

update rules and snapshots. Operations like ListBuckets obviously w…

dc83a86

…on't have tags for bucket or object key

nhulston force-pushed the nicholas.hulston/add-s3-instrumentation branch from e42f14c to e7edd48 Compare February 3, 2025 18:16

nhulston requested a review from DylanLovesCoffee February 3, 2025 18:45

fix localstack checksum error in ci. aws/aws-sdk-net#3610

6fca491

nhulston force-pushed the nicholas.hulston/add-s3-instrumentation branch from e7edd48 to 6fca491 Compare February 3, 2025 20:06

Merge branch 'master' into nicholas.hulston/add-s3-instrumentation

340942b

nhulston commented Feb 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tracer] Add s3 instrumentation #6590

[tracer] Add s3 instrumentation #6590

nhulston commented Jan 23, 2025 •

edited

Loading

datadog-ddstaging bot commented Jan 23, 2025 •

edited

Loading

andrewlock commented Jan 23, 2025 •

edited

Loading

andrewlock commented Jan 23, 2025 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6590

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6590

Raw results

Raw results

Raw results

Raw results

nhulston Feb 4, 2025

[tracer] Add s3 instrumentation #6590

Are you sure you want to change the base?

[tracer] Add s3 instrumentation #6590

Conversation

nhulston commented Jan 23, 2025 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Jan 23, 2025 • edited Loading

Datadog Report

andrewlock commented Jan 23, 2025 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Jan 23, 2025 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6590

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6590

Raw results

Raw results

Raw results

Raw results

nhulston Feb 4, 2025

Choose a reason for hiding this comment

nhulston commented Jan 23, 2025 •

edited

Loading

datadog-ddstaging bot commented Jan 23, 2025 •

edited

Loading

andrewlock commented Jan 23, 2025 •

edited

Loading

andrewlock commented Jan 23, 2025 •

edited

Loading