Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crysmags/ Adding support for Undici #4293

Merged
merged 11 commits into from
Jun 10, 2024
Merged

crysmags/ Adding support for Undici #4293

merged 11 commits into from
Jun 10, 2024

Conversation

crysmags
Copy link
Collaborator

@crysmags crysmags commented May 9, 2024

What does this PR do?

This will add support for Undici for current versions of Undici that support fetch (versions '^4.4.1', '5', '^6.0.0'). It will also support diagnostics channel when it is supported by Undici.

Plugin Checklist

Additional Notes

@crysmags crysmags requested review from a team as code owners May 9, 2024 17:18
Copy link

github-actions bot commented May 9, 2024

Overall package size

Self size: 6.67 MB
Deduped: 61.93 MB
No deduping: 62.21 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (02dc5ce) to head (2572f06).
Report is 8 commits behind head on master.

Current head 2572f06 differs from pull request most recent head ea31977

Please upload reports for the commit ea31977 to get more accurate results.

Files Patch % Lines
packages/dd-trace/src/plugins/index.js 0.00% 1 Missing ⚠️
...ages/dd-trace/src/service-naming/schemas/v0/web.js 0.00% 1 Missing ⚠️
...ages/dd-trace/src/service-naming/schemas/v1/web.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4293       +/-   ##
===========================================
+ Coverage   69.19%   84.87%   +15.68%     
===========================================
  Files           1      256      +255     
  Lines         198    11228    +11030     
  Branches       33       33               
===========================================
+ Hits          137     9530     +9393     
- Misses         61     1698     +1637     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented May 9, 2024

Benchmarks

Benchmark execution time: 2024-06-10 21:03:34

Comparing candidate commit ea31977 in PR branch undici_pr with baseline commit 2db2ea5 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@tlhunter tlhunter force-pushed the undici_pr branch 5 times, most recently from 7387a6e to 8dd1be7 Compare May 10, 2024 22:02
packages/datadog-instrumentations/src/undici.js Outdated Show resolved Hide resolved
packages/dd-trace/src/plugin_manager.js Outdated Show resolved Hide resolved
@crysmags crysmags force-pushed the undici_pr branch 2 times, most recently from 607670d to ac424fd Compare May 24, 2024 23:43
Qard
Qard previously approved these changes May 27, 2024
Copy link
Contributor

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a small bit probably leftover from debugging tests, but otherwise LGTM.

packages/datadog-plugin-undici/test/index.spec.js Outdated Show resolved Hide resolved
@crysmags crysmags force-pushed the undici_pr branch 3 times, most recently from 9ec9edf to b0a3d0d Compare June 10, 2024 17:42
@crysmags crysmags dismissed rochdev’s stale review June 10, 2024 20:53

These changes have been made and Roch is on PTO

@crysmags crysmags changed the title Adding Unidici support crysmags/ Adding support for Undici Jun 10, 2024
@crysmags crysmags merged commit 32a7005 into master Jun 10, 2024
134 checks passed
@crysmags crysmags deleted the undici_pr branch June 10, 2024 21:09
khanayan123 pushed a commit that referenced this pull request Jun 10, 2024
* Adding support Undici's fetch
khanayan123 pushed a commit that referenced this pull request Jun 10, 2024
* Adding support Undici's fetch
This was referenced Jun 10, 2024
khanayan123 pushed a commit that referenced this pull request Jun 10, 2024
* Adding support Undici's fetch
khanayan123 pushed a commit that referenced this pull request Jun 10, 2024
* Adding support Undici's fetch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants