Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLOBS-879] Add tests to openai streaming #4346

Merged
merged 9 commits into from
May 24, 2024

Conversation

jjxct
Copy link
Contributor

@jjxct jjxct commented May 24, 2024

What does this PR do?

This PR adds 3 tests to the OpenAI library, specifically to the endpoints completion and chat/completion using the stream=true parameter.

  • Test for simple completion
  • Test for chat completion with tool calls
  • Test for empty stream returned from stream call doesn’t break instrumentation

Motivation

Plugin Checklist

Additional Notes

@jjxct jjxct requested review from a team as code owners May 24, 2024 00:42
@jjxct jjxct changed the base branch from master to sabrenner/openai-streaming May 24, 2024 00:43
@jjxct jjxct requested a review from a team as a code owner May 24, 2024 00:43
Copy link

github-actions bot commented May 24, 2024

Overall package size

Self size: 6.53 MB
Deduped: 60.67 MB
No deduping: 60.95 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@jjxct jjxct force-pushed the jonathan.chavez/oai-streaming branch from a2da630 to 6187bfb Compare May 24, 2024 00:45
@jjxct jjxct force-pushed the sabrenner/openai-streaming branch from 9435181 to cc4352a Compare May 24, 2024 00:46
@jjxct jjxct removed request for a team and romainkomorndatadog May 24, 2024 00:50
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (cc4352a) to head (6447a46).

Current head 6447a46 differs from pull request most recent head b8c4a29

Please upload reports for the commit b8c4a29 to get more accurate results.

Additional details and impacted files
@@                      Coverage Diff                       @@
##           sabrenner/openai-streaming    #4346      +/-   ##
==============================================================
+ Coverage                       82.20%   88.71%   +6.51%     
==============================================================
  Files                             245      246       +1     
  Lines                           10350    10416      +66     
  Branches                           33       33              
==============================================================
+ Hits                             8508     9241     +733     
+ Misses                           1842     1175     -667     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented May 24, 2024

Benchmarks

Benchmark execution time: 2024-05-24 01:15:07

Comparing candidate commit 25c6433 in PR branch jonathan.chavez/oai-streaming with baseline commit cc4352a in branch sabrenner/openai-streaming.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 262 metrics, 3 unstable metrics.

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-159.873MB; -99.355MB] or [-16.642%; -10.342%]

@Yun-Kim Yun-Kim self-requested a review May 24, 2024 16:51
@jjxct jjxct merged commit 1efbb63 into sabrenner/openai-streaming May 24, 2024
13 of 15 checks passed
@jjxct jjxct deleted the jonathan.chavez/oai-streaming branch May 24, 2024 17:29
jjxct added a commit that referenced this pull request May 24, 2024
* yarn

* add remaining tests

* remove yarn files

* add yarn lock back

* format

* fix lint

* fix test

* fix lints

* Update packages/datadog-plugin-openai/test/index.spec.js

Co-authored-by: Yun Kim <[email protected]>

---------

Co-authored-by: Yun Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants