v5.33.1 proposal #5175
Merged
v5.33.1 proposal #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Validate YAML files using actionlint * Check that tests in packages/datadog-instrumentations/tests/ are actually run. * Check that tests in packages/datadog-plugin-*/tests/ are actually run. * Ensure all tests have the same triggers.
…to the default exchange were setting checkpoints that didn't work in DSM (#5150)
* wip utilities * fixes * add tests * update comment * update * add math.random stubs to test hooks * fix
If the user updates package.json in a PR, we need to ensure that the yarn.lock file is also updated in the same PR. This change will fail the `yarn install` command in case the yarn.lock is not in sync with package.json.
* Use profiler 5.5.1
szegedi
force-pushed
the
v5.33.1-proposal
branch
from
55f217e to
40eeac4
Compare
Overall package sizeSelf size: 8.54 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| with: | ||
| node-version: '18' | ||
| - uses: ./.github/actions/install | ||
| - run: yarn test:trace:core:ci | ||
| - uses: codecov/codecov-action@v3 | ||
| - uses: codecov/codecov-action@v5 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
| @@ -51,7 +51,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: actions/setup-node@v3 | |||
| - uses: actions/setup-node@v4 | |||
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
| env: | ||
| PLUGINS: multer | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
| @@ -315,7 +315,7 @@ jobs: | |||
| uses: ./.github/actions/testagent/logs | |||
| with: | |||
| suffix: plugins-${{ github.job }} | |||
| - uses: codecov/codecov-action@v3 | |||
| - uses: codecov/codecov-action@v5 | |||
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
|
|
||
| windows: | ||
| runs-on: windows-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/setup-node@v4 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
| @@ -13,7 +13,7 @@ jobs: | |||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: actions/setup-node@v3 | |||
| - uses: actions/setup-node@v4 | |||
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
| actionlint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
|
|
||
| windows: | ||
| runs-on: windows-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/setup-node@v4 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
| @@ -48,7 +48,7 @@ jobs: | |||
| # queries: ./path/to/local/query, your-org/your-repo/queries@main | |||
|
|
|||
| - name: Autobuild | |||
| uses: github/codeql-action/autobuild@v2 | |||
| uses: github/codeql-action/autobuild@v3 | |||
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
| @@ -11,7 +11,7 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| fetch-depth: 0 | |||
| - uses: actions/setup-node@v3 | |||
| - uses: actions/setup-node@v4 | |||
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v5.x #5175 +/- ##
=======================================
Coverage ? 82.50%
=======================================
Files ? 442
Lines ? 19573
Branches ? 0
=======================================
Hits ? 16148
Misses ? 3425
Partials ? 0 ☔ View full report in Codecov by Sentry. |
watson
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ff05e3b873] - (SEMVER-PATCH) Fix a crash in the profiler (Attila Szegedi) #51742a90a11519] - (SEMVER-PATCH) [CI] Do not allow yarn.lock to be updated in CI (Thomas Watson) #5135c0550a027e] - (SEMVER-PATCH) chore: add some shared llm-type plugin utilities (Sam Brenner) #5109f5bec490f0] - (SEMVER-PATCH) [DSM] Fix an issue where RabbitMQ producers when producing a message to the default exchange were setting checkpoints that didn't work in DSM (Eric Firth) #51504f22cf70de] - (SEMVER-PATCH) Add more YAML verification (Bryan English) #5151