-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: cargo clippy --fix and fmt on Rust v1.84 #3032
Conversation
Benchmarks [ profiler ]Benchmark execution time: 2025-01-13 08:33:54 Comparing candidate commit 6f85678 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3032 +/- ##
=========================================
Coverage 72.92% 72.92%
Complexity 2781 2781
=========================================
Files 139 139
Lines 15166 15166
Branches 1022 1022
=========================================
Hits 11060 11060
Misses 3554 3554
Partials 552 552
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ❤️
Signed-off-by: Bob Weinand <[email protected]>
Despite failing tests, we have merged this in. The main failures are unrelated to this PR (windows failures) so they can be fixed in other PRs. |
Description
I think there are some
static mut
uses and other things clippy should be complaining about in CI, but it's not. While investigating why we aren't getting more clippy errors, I figured I'd runcargo +1.84 clippy fix
while I was at it.We also fix some other small things with the build so that tests pass. Thanks Bob and Florian for contributing those.
Reviewer checklist