Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: cargo clippy --fix and fmt on Rust v1.84 #3032

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

morrisonlevi
Copy link
Collaborator

@morrisonlevi morrisonlevi commented Jan 10, 2025

Description

I think there are some static mut uses and other things clippy should be complaining about in CI, but it's not. While investigating why we aren't getting more clippy errors, I figured I'd run cargo +1.84 clippy fix while I was at it.

We also fix some other small things with the build so that tests pass. Thanks Bob and Florian for contributing those.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi morrisonlevi requested a review from a team as a code owner January 10, 2025 16:09
@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing labels Jan 10, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2025

Benchmarks [ profiler ]

Benchmark execution time: 2025-01-13 08:33:54

Comparing candidate commit 6f85678 in PR branch levi/fix-clippy with baseline commit 9607a5f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.92%. Comparing base (9607a5f) to head (6f85678).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3032   +/-   ##
=========================================
  Coverage     72.92%   72.92%           
  Complexity     2781     2781           
=========================================
  Files           139      139           
  Lines         15166    15166           
  Branches       1022     1022           
=========================================
  Hits          11060    11060           
  Misses         3554     3554           
  Partials        552      552           
Flag Coverage Δ
appsec-extension 67.99% <ø> (ø)
tracer-php 74.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9607a5f...6f85678. Read the comment docs.

Copy link
Member

@realFlowControl realFlowControl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ❤️

@morrisonlevi morrisonlevi requested a review from a team as a code owner January 10, 2025 22:25
@morrisonlevi morrisonlevi merged commit c73b7f7 into master Jan 13, 2025
749 of 790 checks passed
@morrisonlevi morrisonlevi deleted the levi/fix-clippy branch January 13, 2025 16:06
@github-actions github-actions bot added this to the 1.7.0 milestone Jan 13, 2025
@morrisonlevi
Copy link
Collaborator Author

Despite failing tests, we have merged this in. The main failures are unrelated to this PR (windows failures) so they can be fixed in other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants