Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the output parsing on the latest semgrep tool #517

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Fix the output parsing on the latest semgrep tool #517

merged 6 commits into from
Feb 4, 2025

Conversation

sobregosodd
Copy link
Contributor

  • Rewrite the JSON output parsing so as not to use extra.lines
  • Eliminate symbolic-propagation and extend the affected rules to pass tests

@sobregosodd sobregosodd marked this pull request as ready for review January 14, 2025 16:34
ikretz
ikretz approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@ikretz ikretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sobregosodd sobregosodd changed the title Comply with semgrep licence changes Fix the output parsing on the latest semgrep tool Jan 15, 2025
@sobregosodd sobregosodd merged commit 4723efb into main Feb 4, 2025
9 checks passed
@sobregosodd sobregosodd deleted the s.obregoso/semgrep_newlicence_adoption branch February 4, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

@ikretz ikretz ikretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobregosodd @ikretz