Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin Detection: Send both container ID and entity ID #241

Merged
merged 8 commits into from
Jun 6, 2024

Conversation

gh123man
Copy link
Member

@gh123man gh123man commented May 7, 2024

We would like customers to be able to retrieve container tags even when DD_ENTITY_ID is set. The current behavior does not send the container-id if the entity id is set.

This PR implements the same changes seen in these PRs:
DataDog/datadog-go#300
DataDog/datadogpy#828

Background

UDP support for origin detection was first introduced in 7.51 However it was difficult to use due to the combination of settings required. With 7.54+ you can enable DD_ORIGIN_DETECTION_UNIFIED and it will "just work".

After this change with DD_ORIGIN_DETECTION_UNIFIED users can control origin tags by simply changing the cardinality setting (to high for container level tags). This PR ultimately helps conform to the new origin detection architecture in the agent: Clients should send "Everything" (all data needed for origin detection), the agent should ingest everything, and cardinality controls which tags actually get sent.

The old behavior is maintained by omitting the DD_ORIGIN_DETECTION_UNIFIED in the agent which will cause the tagger to fall back to legacy mode. This will eventually be removed.

@gh123man gh123man marked this pull request as ready for review May 9, 2024 18:48
@gh123man gh123man requested a review from a team as a code owner May 9, 2024 18:48
@gh123man
Copy link
Member Author

gh123man commented Jun 4, 2024

image

Tested and confirmed with agent 7.54.0

Copy link
Contributor

@vickenty vickenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please summarize difference in behavior in the PR description? Does the behavior depend on the agent version?

Is there a way to get old behavior? I see it mentioned on the other PRs, will it be applicable here? Might be nice to mention this too.

@gh123man gh123man merged commit f052e9a into master Jun 6, 2024
12 checks passed
@gh123man gh123man deleted the brian/AMLII-1676-send-both-cid-entity-id branch June 6, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants