Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parametric: re-enable config consistency tests for ruby #3381

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Nov 5, 2024

Motivation

Resolves the following errors: https://github.com/DataDog/system-tests/actions/runs/11689546728/job/32553275066 in the v2.5.0 release of the ruby tracer.

This PR updates the ruby tracer so it works with previous implementation of Test_Config_UnifiedServiceTagging::test_specific_version

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur mabdinur changed the title parametric: ensure config consistency tests are compatible with ruby [WIP] parametric: ensure config consistency tests are compatible with ruby Nov 13, 2024
@mabdinur mabdinur changed the title parametric: ensure config consistency tests are compatible with ruby parametric: re-enable config consistency tests for ruby Nov 18, 2024
@mabdinur mabdinur marked this pull request as ready for review November 18, 2024 16:15
@mabdinur mabdinur requested review from a team as code owners November 18, 2024 16:15
@mabdinur mabdinur requested review from mcculls and removed request for a team November 18, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant