Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] add test-app-python-36 app for INSTALLER_NOT_SUPPORTED_AUTO_INJECTION #3438

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

brettlangdon
Copy link
Member

Motivation

We are currently not running the INSTALLER_NOT_SUPPORTED_AUTO_INJECTION scenario for Python. This change adds a test case for that.

Changes

Adds a new test-app-python-36 VM weblog so we can test older/unsupported versions of Python.

Starts running the INSTALLER_NOT_SUPPORTED_AUTO_INJECTION scenario with this new app.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the problems you had with RH9 be the problems we detected yesterday? In that case the failures would not be because of this PR and you could re-include RH9.

@@ -653,7 +653,7 @@ def __init__(self, **kwargs) -> None:
krunvm_config=None,
os_type="linux",
os_distro="rpm",
os_branch="redhat",
os_branch="redhat_9",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change this you have to be careful with this: link

and with this: link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants