Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[golang] Cleanup weblog codeowner broadening #3480

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[golang] Cleanup weblog codeowner broadening #3480

wants to merge 2 commits into from
+103 −127

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Nov 18, 2024 •
edited
Loading

Motivation

We are working to add orchestrion to the current set of weblogs. Iterating faster will be of great help

Changes

  • Remove the useless dependency install of jq on weblogs
  • Sync dependencies with the newest version of dd-trace-go for faster weblog docker builds
  • switch the code owners of the go weblogs to dd-trace-go-guild, which is already used on the manifest part of the CODEOWNERS file

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@eliottness eliottness added the go Pull requests that update Go code label Nov 18, 2024
@eliottness eliottness self-assigned this Nov 18, 2024
@eliottness eliottness marked this pull request as ready for review November 18, 2024 16:45
@eliottness eliottness requested review from a team as code owners November 18, 2024 16:45
@eliottness eliottness changed the title [golang] Cleanup and upgrade dependencies [golang] Cleanup weblog codeowner broadening Nov 18, 2024
cbeauchesne
cbeauchesne requested changes Nov 18, 2024
View reviewed changes
.github/CODEOWNERS
@@ -2,7 +2,7 @@

/utils/build/docker/cpp/ @DataDog/dd-trace-cpp @DataDog/system-tests-core
/utils/build/docker/dotnet*/ @DataDog/apm-dotnet @DataDog/asm-dotnet @DataDog/system-tests-core
/utils/build/docker/golang*/ @DataDog/apm-go @DataDog/system-tests-core
/utils/build/docker/golang*/ @DataDog/guild-dd-trace-go @DataDog/system-tests-core
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the good name ? https://github.com/orgs/DataDog/teams/dd-trace-go-guild

mtoffl01
mtoffl01 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@mtoffl01 mtoffl01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me, so long as Charles' comment is addressed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeauchesne cbeauchesne cbeauchesne requested changes

@mtoffl01 mtoffl01 mtoffl01 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@eliottness eliottness

Labels
go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliottness @cbeauchesne @mtoffl01