Refactor delete method to not remove empty directories

DataONEorg · Dec 29, 2023 · f704389 · f704389
1 parent 255673e
commit f704389
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/hashstore/filehashstore.py b/src/hashstore/filehashstore.py
@@ -1857,10 +1857,12 @@ def delete(self, entity, file):
 
         try:
             os.remove(realpath)
-        except OSError:
-            pass
-        else:
-            self._remove_empty(os.path.dirname(realpath))
+        except OSError as err:
+            exception_string = (
+                f"FileHashStore - delete(): Unexpected {err=}, {type(err)=}"
+            )
+            logging.error(exception_string)
+            raise err
 
     def _remove_empty(self, subpath):
         """Successively remove all empty folders starting with `subpath` and